Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(formatting): revise README #316

Merged
merged 2 commits into from
Apr 18, 2024
Merged

style(formatting): revise README #316

merged 2 commits into from
Apr 18, 2024

Conversation

christinaausley
Copy link
Contributor

@christinaausley christinaausley added kind/documentation Categorizes issue or PR as related to documentation. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ labels Feb 26, 2024
@christinaausley christinaausley self-assigned this Feb 26, 2024
@akeller
Copy link
Member

akeller commented Feb 26, 2024

I should be able to review this tomorrow, but I might not be able to get to it until next week.

I added a few other reviewers/stakeholders. They can delegate if necessary.


Find the finished process at [process/send-email.bpmn](process/send-email.bpmn).
To create the process, use [Modeler](https://docs.camunda.io/docs/components/modeler/about-modeler/).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty blunt. Do we want to walk users through this portion of the guide? I've added "Find the finished process at process/send-email.bpmn, and learn more about designing a process using BPMN." but this may not be enough.

Copy link
Contributor

@megglos megglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, just noticed this overdue open reviewe request in my PR overview 🙈
I'm in favor of merging this as it already is a great improvement, I have some thoughts on you comments which may lead to more changes. Happy to discuss them to conclude and make a decision.

@christinaausley
Copy link
Contributor Author

@megglos -- merging this in with plans to open another PR to resolve these comments 👍

@christinaausley christinaausley merged commit dd915ad into main Apr 18, 2024
6 checks passed
@christinaausley christinaausley deleted the docs-revise-readme branch April 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants