use contentType from Document metadata when uploading a Document with…

… REST (#4121)
camunda · Feb 24, 2025 · 1e0501a · 1e0501a
1 parent d40ff5b
commit 1e0501a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.../io/camunda/connector/http/base/client/apache/builder/parts/ApacheRequestBodyBuilder.java b/.../io/camunda/connector/http/base/client/apache/builder/parts/ApacheRequestBodyBuilder.java
@@ -142,10 +142,16 @@ private HttpEntity createMultiPartEntity(Map<?, ?> body, ContentType contentType
   private void streamDocumentContent(
       Map.Entry<?, ?> entry, Document document, MultipartEntityBuilder builder) {
     DocumentMetadata metadata = document.metadata();
+    ContentType contentType;
+    try {
+      contentType = ContentType.create(metadata.getContentType());
+    } catch(IllegalArgumentException e){
+      contentType = ContentType.DEFAULT_BINARY;
+    }
     builder.addBinaryBody(
         String.valueOf(entry.getKey()),
         new BufferedInputStream(document.asInputStream()),
-        ContentType.DEFAULT_BINARY,
+        contentType,
         metadata.getFileName());
   }
 }
diff --git a/...rc/test/java/io/camunda/connector/http/base/client/apache/CustomApacheHttpClientTest.java b/...rc/test/java/io/camunda/connector/http/base/client/apache/CustomApacheHttpClientTest.java
@@ -126,6 +126,7 @@ public void shouldReturn201_whenUploadDocument(WireMockRuntimeInfo wmRuntimeInfo
           store.createDocument(
               DocumentCreationRequest.from("The content of this file".getBytes())
                   .fileName("file.txt")
+                  .contentType("text/plain")
                   .build());
       HttpCommonRequest request = new HttpCommonRequest();
       request.setMethod(HttpMethod.POST);
@@ -153,6 +154,7 @@ public void shouldReturn201_whenUploadDocument(WireMockRuntimeInfo wmRuntimeInfo
                   new MultipartValuePatternBuilder()
                       .withName("document")
                       .withBody(equalTo("The content of this file"))
+                      .withHeader("Content-Type", equalTo("text/plain"))
                       .build()));
     }
   }