-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Documentation and Example data sections for Connector templates #1401
Comments
@sbuettner based on https://camunda.slack.com/archives/C06SBNKJHS6/p1715080678353749, are the team able to pick this up and get it done for the next alpha release after this one that's currently happening. |
We should keep an eye on how the example data is handled in the Web Modeler's auto complete. E.g., if there is a result expression applied it should not propagate to the rest of the diagram (slack thread) |
@crobbins215, do you have a timeframe when this will be implemented? |
Its priority is set up as ready and now so should get picked up soon. FYI @sbuettner |
The documentation part is already available. Regarding the example data, the question is whether it should be available for all connectors. Note that sometimes the template developer may provide the example data (in case of specialized templates), and in other cases it is the user's responsibility (generic REST connector). Example: Also, I can already define such a field to be filled in by the user. So the template developer has full control (though it's undocumented). |
The example data issue: bpmn-io/bpmn-js-element-templates#104 |
See also https://github.com/camunda/example-data-properties-provider/blob/main/test/fixtures/templates.json for how one could implement example output in the templates. |
X-Posting and summarizing the discussion from slack: Core Problem:Core use-case for the Play team is to mock output using example data. Modeler integration for this is not strictly necessary, but could improve modeling experience. However, this will require a custom variable provider that is connector specific. Current State:The Documentation Field is already available in Templated Tasks. For Example data, the template must support it and explicitly add it as a field. Cf. @barmac's comments above. Suggested Solution (in this ticket)Add Example data section to templated elements. Adding the Example data field has some problems:
The example data provider was not designed to work in this way, but as a MVP for simple use cases. The variable system is pluggable. It would be easier to create an additional data provider that allows better code intelligence for this case and solve both problems we are facing. |
Is your feature request related to a problem? Please describe.
Currently the are no Documentation and Example data sections in Connector templates as it's for generic element types.
Describe the solution you'd like
Documentation and Example data sections are visible on activity when Connector template is selected.
The text was updated successfully, but these errors were encountered: