Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql): Add JSON support #3972

Merged
merged 2 commits into from
Feb 18, 2025
Merged

feat(sql): Add JSON support #3972

merged 2 commits into from
Feb 18, 2025

Conversation

ztefanie
Copy link
Contributor

@ztefanie ztefanie commented Feb 7, 2025

Description

Added JSON parsing for string columns.
Added Uni Tests for all sql specific json columns

Related issues

closes #3895

Checklist

  • PR has a milestone or the no milestone label.

@ztefanie ztefanie added this to the 8.8.0-alpha2 milestone Feb 7, 2025
@ztefanie ztefanie requested a review from a team as a code owner February 7, 2025 11:35
@ztefanie ztefanie force-pushed the 3895-sql-connector-add-json-support branch 2 times, most recently from b3eaa4c to 4b5a24d Compare February 10, 2025 14:35
@ztefanie ztefanie force-pushed the 3895-sql-connector-add-json-support branch from efae941 to cde0ea0 Compare February 11, 2025 09:52
johnBgood
johnBgood previously approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@ztefanie ztefanie force-pushed the 3895-sql-connector-add-json-support branch 2 times, most recently from 9518e99 to 95edfb0 Compare February 12, 2025 07:14
@ztefanie ztefanie requested a review from johnBgood February 12, 2025 07:14
@ztefanie ztefanie force-pushed the 3895-sql-connector-add-json-support branch from 95edfb0 to f49c2d3 Compare February 12, 2025 08:11
@ztefanie ztefanie added the qa:required Will trigger the QA workflow label Feb 12, 2025
@johnBgood
Copy link
Collaborator

johnBgood commented Feb 12, 2025 •
edited by ztefanie
Loading

QA information

Test Environment

  • Test required in (you can check both):
    • SaaS
    • SM
  • Create a new test for this feature in our Pre Release Tests for @Szik to be able to test

Test Scope

Please describe the test scope, happy path, edge cases that come to your mind, and whatever you think might relevant to test

  • Some SQL databases support JSON datatypes. These are for the most common SQL dialects:
    Microsoft SQL Server: None
    MySQL: JSON
    PostgreSQL: json and jsonb
    MariaDB: JSON
  • when these column types are used, it should be possible to access the values of the keys with feel. Check the attached BPMN for reference how this should work.

Test Data

Please provide the test data, if needed (files, URLs, code snippets, FEEL expressions)
The BPMN which connects to a aws postgres database and check for this: https://modeler.ultrawombat.com/diagrams/317bbd37-8166-419f-9223-8c077a61e15c--json_parsing?v=489,260,1
I coundn't yet figure out how to run this BPMN so it may not work as expected, but at least locally it worked as expected.

@ztefanie ztefanie removed the request for review from mathias-vandaele February 14, 2025 09:30
@ztefanie ztefanie force-pushed the 3895-sql-connector-add-json-support branch from 3e74f9e to fed4513 Compare February 14, 2025 10:37
@ztefanie
Copy link
Contributor Author

/backport

@team-connectors-int-automation
Copy link

Only merged pull requests can be backported.

@ztefanie ztefanie force-pushed the 3895-sql-connector-add-json-support branch from fed4513 to 8d7b1ff Compare February 17, 2025 13:36
sbuettner
sbuettner approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@sbuettner sbuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ztefanie ztefanie added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit fba43b6 Feb 18, 2025
13 of 15 checks passed
@ztefanie ztefanie deleted the 3895-sql-connector-add-json-support branch February 18, 2025 07:15
team-connectors-int-automation bot pushed a commit that referenced this pull request Feb 18, 2025
@ztefanie @github-actions
feat(sql): Add JSON support (#3972)
63b7b55 
* feat(sql): Add JSON support for SQL databases

* improve performance for json mapping

(cherry picked from commit fba43b6)
@team-connectors-int-automation
Copy link

Successfully created backport PR for release/8.7:

@team-connectors-int-automation team-connectors-int-automation bot mentioned this pull request Feb 18, 2025
Merged
mathias-vandaele pushed a commit that referenced this pull request Feb 19, 2025
@ztefanie @mathias-vandaele
feat(sql): Add JSON support (#3972)
7b3c92c 
* feat(sql): Add JSON support for SQL databases

* improve performance for json mapping

(cherry picked from commit fba43b6)
ztefanie added a commit that referenced this pull request Feb 20, 2025
@ztefanie
feat(sql): Add JSON support (#3972)
e09d3f0 
* feat(sql): Add JSON support for SQL databases

* improve performance for json mapping

(cherry picked from commit fba43b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbuettner sbuettner sbuettner approved these changes

@johnBgood johnBgood Awaiting requested review from johnBgood

Assignees

@Szik Szik

Labels
backport release/8.7 deploy-preview qa:required Will trigger the QA workflow
Projects
None yet
Milestone
8.8.0-alpha2
Development

Successfully merging this pull request may close these issues.

[SQL Connector] Add JSON support
4 participants
@ztefanie @johnBgood @sbuettner @Szik