feat(slack): add attachments support #4119
Conversation
DenovVasil
force-pushed
the
1003-support-slack-attachments
branch
2 times, most recently
from
603b63c to
13c592f
Compare
QA informationTest Environment
Test ScopePlease describe the test scope, happy path, edge cases that come to your mind, and whatever you think might relevant to test Test DataPlease provide the test data, if needed (files, URLs, code snippets, FEEL expressions) |
| } | ||
| } | ||
|
|
||
| private List<File> completeFileUpload( |
There was a problem hiding this comment.
is it a bit weird to get a list as a return type when uploading a single Document? It also forces us to flatMap above.
There was a problem hiding this comment.
makes sense, then we will have to add a method that will get the first (single) file. Such code will seem a little strange at first glance, but more self-descriptive
| return completeUploadResp.getFiles(); | ||
| } else { | ||
| String msg = COMPLETE_UPLOAD_CALL_EX + "\n Errors: " + completeUploadResp.getError(); | ||
| LOGGER.warn(msg); |
There was a problem hiding this comment.
For me warn is ok, but I'm not the one who works a lot with our logs, so I'd be grateful if you could offer a more suitable level
DenovVasil
force-pushed
the
1003-support-slack-attachments
branch
from
13c592f to
b0ee23e
Compare
|
/backport |
|
Only merged pull requests can be backported. |
(cherry picked from commit c95a1a9)
|
Successfully created backport PR for |
🚀 Deployment Results 🚀Please find below the results of the latest deployments.
|
(cherry picked from commit c95a1a9)
Description
slack attachments feat
demo
2025-02-24.17-16-36.mov
Related issues
documentation PR: camunda/camunda-docs#5081
template PR(with increased version) https://github.com/camunda/web-modeler/pull/13224
closes #
Checklist
no milestonelabel.