Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: align camunda model version to 7.22 with camunda/camunda #1494

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

megglos
Copy link
Contributor

@megglos megglos commented Feb 17, 2025

Description

Quick fix for potential issues caused by the version misalignment. It's a bit unfortunate this needs manual alignment, on the other hand it's not the only dep that needs to stay aligned and this one is rather infrequent to change.

Related issues

closes #1493

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@megglos
Copy link
Contributor Author

megglos commented Feb 17, 2025

For reference, this applies also to main, 8.7, 8.5, 8.4

Copy link

github-actions bot commented Feb 17, 2025

Test Results

 45 files  ±0   45 suites  ±0   1m 26s ⏱️ -1s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
414 runs  ±0  414 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 93366e3. ± Comparison against base commit 5aa1afc.

♻️ This comment has been updated with latest results.

@megglos megglos force-pushed the meg-1493-model-dep-fix branch from a89f3a8 to 93366e3 Compare February 17, 2025 07:34
@megglos megglos changed the base branch from stable/8.7 to stable/8.6 February 17, 2025 07:34
@megglos megglos added backport stable/8.7 Backport change to stable/8.7 and removed backport stable/8.6 labels Feb 17, 2025
@megglos megglos closed this Feb 17, 2025
@megglos megglos reopened this Feb 17, 2025
@megglos megglos requested a review from eppdot February 17, 2025 07:41
Copy link

@eppdot eppdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for fixing it right away

@megglos megglos merged commit cc1edd9 into stable/8.6 Feb 17, 2025
11 checks passed
@megglos megglos deleted the meg-1493-model-dep-fix branch February 17, 2025 08:15
@backport-action
Copy link
Collaborator

Backport failed for stable/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.4
git worktree add -d .worktree/backport-1494-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-1494-to-stable/8.4
git switch --create backport-1494-to-stable/8.4
git cherry-pick -x cc1edd973a15242317af26b329d5431ffc22c387

@backport-action
Copy link
Collaborator

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin main
git worktree add -d .worktree/backport-1494-to-main origin/main
cd .worktree/backport-1494-to-main
git switch --create backport-1494-to-main
git cherry-pick -x cc1edd973a15242317af26b329d5431ffc22c387

@backport-action
Copy link
Collaborator

Backport failed for stable/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.5
git worktree add -d .worktree/backport-1494-to-stable/8.5 origin/stable/8.5
cd .worktree/backport-1494-to-stable/8.5
git switch --create backport-1494-to-stable/8.5
git cherry-pick -x cc1edd973a15242317af26b329d5431ffc22c387

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.7:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants