Skip to content

Commit 01a73f0

Browse files
committed
🐞 fix: Change shell to bash for V8 build on Windows
1 parent 038f6a3 commit 01a73f0

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

Diff for: .github/workflows/windows_x86_64_build.yml

+9-8
Original file line numberDiff line numberDiff line change
@@ -49,25 +49,26 @@ jobs:
4949
- name: Build V8
5050
env:
5151
DEPOT_TOOLS_WIN_TOOLCHAIN: 0
52+
shell: bash
5253
run: |
53-
cd ${{ env.ROOT }}
54+
cd ..
5455
mkdir google
5556
cd google
5657
git clone --depth=10 --branch=main https://chromium.googlesource.com/chromium/tools/depot_tools.git
5758
cd depot_tools
5859
git checkout remotes/origin/main
5960
cd ..
60-
.\depot_tools\fetch.bat v8
61+
fetch v8
6162
cd v8
6263
git checkout ${{ env.JAVET_V8_VERSION }}
6364
cd ..
64-
.\depot_tools\gclient.bat sync -D
65+
gclient sync -D
6566
cd v8
66-
python3 tools\dev\v8gen.py x64.release -- v8_monolithic=true v8_use_external_startup_data=false is_component_build=false ${{ matrix.v8_flag }} v8_enable_pointer_compression=false v8_static_library=true symbol_level=0 use_custom_libcxx=false v8_enable_sandbox=false
67-
..\depot_tools\gn.bat gen out.gn/x64.release
68-
python3 ${{ env.ROOT }}\Javet\scripts\python\patch_v8_build.py -p .\
69-
..\depot_tools\ninja.bat -C out.gn/x64.release v8_monolith || python3 ${{ env.ROOT }}\Javet\scripts\python\patch_v8_build.py -p .\
70-
..\depot_tools\ninja.bat -C out.gn/x64.release v8_monolith
67+
python3 tools/dev/v8gen.py x64.release -- v8_monolithic=true v8_use_external_startup_data=false is_component_build=false ${{ matrix.v8_flag }} v8_enable_pointer_compression=false v8_static_library=true symbol_level=0 use_custom_libcxx=false v8_enable_sandbox=false
68+
gn gen out.gn/x64.release
69+
python3 ../Javet/scripts/python/patch_v8_build.py -p ./
70+
ninja -C out.gn/x64.release v8_monolith || python3 ../Javet/scripts/python/patch_v8_build.py -p ./
71+
ninja -C out.gn/x64.release v8_monolith
7172
move out.gn out.gn.${{ matrix.name }}
7273
7374
- name: Copy the i18n

0 commit comments

Comments
 (0)