🐞 fix: Fix improper memory span in Node.js mode

caoccao · caoccao · commit 8317c80d54c9 · 2024-04-09T12:19:36.000+08:00
diff --git a/cpp/jni/javet_jni_module.cpp b/cpp/jni/javet_jni_module.cpp
@@ -77,11 +77,17 @@ JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_moduleCreate
                     }
                 }
             }
+#ifndef ENABLE_NODE
             v8::MemorySpan<const V8LocalString> exportNamesMemorySpan(exportNames.begin(), exportNames.end());
+#endif
             auto v8LocalModule = v8::Module::CreateSyntheticModule(
                 v8Context->GetIsolate(),
                 Javet::Converter::ToV8String(jniEnv, v8Context, mModuleName),
+#ifdef ENABLE_NODE
+                exportNames,
+#else
                 exportNamesMemorySpan,
+#endif
                 Javet::Callback::JavetSyntheticModuleEvaluationStepsCallback);
             std::string stringKey("module:{}" + std::to_string(v8LocalModule->GetIdentityHash()));
             auto v8LocalStringKey = Javet::Converter::ToV8String(v8Context, stringKey.c_str());

Original file line number	Diff line number	Diff line change
`@@ -77,11 +77,17 @@ JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_moduleCreate`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`	`}`
	`80`	`+#ifndef ENABLE_NODE`
`80`	`81`	`v8::MemorySpan<const V8LocalString> exportNamesMemorySpan(exportNames.begin(), exportNames.end());`
	`82`	`+#endif`
`81`	`83`	`auto v8LocalModule = v8::Module::CreateSyntheticModule(`
`82`	`84`	`v8Context->GetIsolate(),`
`83`	`85`	`Javet::Converter::ToV8String(jniEnv, v8Context, mModuleName),`
	`86`	`+#ifdef ENABLE_NODE`
	`87`	`+ exportNames,`
	`88`	`+#else`
`84`	`89`	`exportNamesMemorySpan,`
	`90`	`+#endif`
`85`	`91`	`Javet::Callback::JavetSyntheticModuleEvaluationStepsCallback);`
`86`	`92`	`std::string stringKey("module:{}" + std::to_string(v8LocalModule->GetIdentityHash()));`
`87`	`93`	`auto v8LocalStringKey = Javet::Converter::ToV8String(v8Context, stringKey.c_str());`