Skip to content

Commit f1b72ac

Browse files
committed
🦄 refactor: Revise link arguments for macos
1 parent 731515d commit f1b72ac

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

cpp/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR CMAKE_SYSTEM_NAME STREQUAL "Android
309309
# https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md
310310
add_subdirectory(${V8_DIR}/third_party/abseil-cpp ${V8_RELEASE_DIR}/third_party/abseil-cpp)
311311
target_link_libraries(Javet PUBLIC -lc++ absl::base absl::time)
312+
target_link_libraries(JavetStatic PUBLIC -lc++ absl::base absl::time)
312313
endif()
313314
if(DEFINED NODE_DIR)
314315
list(APPEND includeDirs
@@ -327,9 +328,8 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR CMAKE_SYSTEM_NAME STREQUAL "Android
327328
# This is a patch build.
328329
# https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md
329330
add_subdirectory(${NODE_DIR}/deps/v8/third_party/abseil-cpp ${NODE_DIR}/out.${OUT_DIR_SUFFIX}/Release/third_party/abseil-cpp)
330-
target_link_libraries(Javet PUBLIC absl::base absl::crc32c absl::time)
331-
target_link_libraries(Javet PUBLIC v8_init)
332-
target_link_libraries(JavetStatic PUBLIC v8_init)
331+
target_link_libraries(Javet PUBLIC v8_init absl::base absl::crc32c absl::time)
332+
target_link_libraries(JavetStatic PUBLIC v8_init absl::base absl::crc32c absl::time)
333333
endif()
334334
# https://caoccao.blogspot.com/2021/08/jni-symbol-conflicts-in-mac-os.html
335335
target_link_libraries(Javet PUBLIC -exported_symbols_list ${CMAKE_SOURCE_DIR}/jni/exported_symbols_list.txt)

0 commit comments

Comments
 (0)