-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Py11 compliant #298
make Py11 compliant #298
Conversation
Sphe makh patch 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing @SpheMakh -- have you tried this with CASA<6 (i.e. python2 based)? Just to make sure that code still runs.
Reminder @SpheMakh -- could you please check this implementation works with CASA5? |
It creates even more parsing problems. But this latest solution works for CASA >=4.7, 5, and 6 |
Ha, so simple in the end! All right, let's merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
basetypes.EmptyClassDefault()
method becausedataclasses
in python 3.11 cannot have mutable (classes in this case) as default values. Updated all the class defaults I could fine. It may be worth considering amethod to our dataclasses then using
foo: Bar = Bar.__default__()
when setting defaults.tempfile
instead of parsing a multi-line code string; this did not work for me.