Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #309. Fixes #310 #311

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fixes #309. Fixes #310 #311

merged 2 commits into from
Jun 10, 2024

Conversation

o-smirnov
Copy link
Member

No description provided.

@o-smirnov o-smirnov requested review from JSKenyon and SpheMakh June 9, 2024 11:42
Copy link
Collaborator

@JSKenyon JSKenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks uncontroversial to me, provided that removing the flatten doesn't have unforeseen consequences.

@o-smirnov
Copy link
Member Author

It does have consequences for hierarchical assignments i.e.

assign:
  log: 
    dir: foo

might not work as expected anymore (has to be assign: log.dir: foo)

I don't think we have recipes in the wild using the former.

@o-smirnov
Copy link
Member Author

P.S. I do feel the assign logic overall is still a little unsettled in places, but I'm happy to muddle forward and let us refine it with more experience.

@o-smirnov o-smirnov merged commit 735ac3a into master Jun 10, 2024
4 checks passed
@o-smirnov o-smirnov deleted the issue-309 branch June 10, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants