Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables list item syntax e.g. =current.foo[2]. Adds option to skip freshness checks #368

Merged
merged 8 commits into from
Mar 3, 2025

Conversation

o-smirnov
Copy link
Member

No description provided.

@o-smirnov o-smirnov requested a review from JSKenyon March 1, 2025 18:42
Copy link
Collaborator

@JSKenyon JSKenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise this looks good to go!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this only supports indexing a single item in a list? Is there a use-case for slicing i.e. list[start:stop:step]?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be, but that would mean adding more grammar to the parser (or else a built-in SLICE function), so maybe let's leave it until demand arises...

@o-smirnov o-smirnov merged commit 757f6fc into master Mar 3, 2025
4 checks passed
@o-smirnov o-smirnov deleted the issue-152 branch March 3, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants