Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model-csvFile-#1468):time level precision not availabe in date #1673

Conversation

RiyaJethwa
Copy link
Contributor

@RiyaJethwa RiyaJethwa commented Oct 3, 2023

Updates

Demo screenshot or recording

image

@RiyaJethwa RiyaJethwa requested review from theiliad, Akshat55 and a team as code owners October 3, 2023 12:56
@RiyaJethwa RiyaJethwa requested review from zvonimirfras and removed request for a team October 3, 2023 12:56
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 23f5616
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/65200f386af9ba00082aedc6
😎 Deploy Preview https://deploy-preview-1673--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 23f5616
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/65200f387c91600008aa6e0c
😎 Deploy Preview https://deploy-preview-1673--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 23f5616
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/65200f38af58a50008856abc
😎 Deploy Preview https://deploy-preview-1673--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RiyaJethwa
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@naegelin
Copy link

naegelin commented Oct 5, 2023

issue #1659 should also be addressed by this fix.

@miedzikd
Copy link

Can I ask if there is any chance to merge that branch? Can I help somehow?

@theiliad
Copy link
Member

theiliad commented Feb 2, 2024

This has already been addressed partially by our tabularRepModal configs
https://charts.carbondesignsystem.com/documentation/interfaces/interfaces.TabularRepCustomizationOptions.html

And will also be addressed by #1710.

Those 2 pieces better address modal customizability (already available), and a general locale interface for dates & numbers (merging soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants