Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1468 #1469

Closed
wants to merge 1 commit into from
Closed

fixes #1468 #1469

wants to merge 1 commit into from

Conversation

naegelin
Copy link

Updates

Fixes #1468

Demo screenshot or recording

New Tabular Representation using  MMM d, yyyy HH:mm:ss

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@naegelin naegelin requested review from theiliad, Akshat55 and a team as code owners November 18, 2022 12:42
@naegelin naegelin requested review from zvonimirfras and removed request for a team November 18, 2022 12:42
@theiliad theiliad closed this Nov 18, 2022
@theiliad
Copy link
Member

Hi, unfortunately we can't modify the default date formatter in our tooltip to include seconds, as this might not apply to many users.

I suggest using the valueFormatter in options.tooltip to add formatting.

You can detect date values there and update the formatting https://charts.carbondesignsystem.com/documentation/interfaces/_interfaces_components_.tooltipoptions.html#valueformatter

Re. adding formatting to the toolbar, I suggest adding that as a feature in a PR. Some kind of a formatter that can run over the table entries.

@naegelin
Copy link
Author

The current tabular representation of a scale referred to as TIME literally does not show or export time.

Your own demo which I have linked in #1468 shows the issue where multiple hours on the same day show the same date repeated over and over with different values because it omits hours.

I would also like to suggest that you not make generalized conclusions about what features may or may not apply to users without allowing for the actual community to comment and participate. In fact some users may be frustrated by the issue as apparent in #1400 which has gone unaddressed for months.

@naegelin
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tabular Data and Tooltip only show date level precision
5 participants