Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1468 #1469

Closed
wants to merge 1 commit into from
Closed

fixes #1468 #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/components/essentials/tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,13 @@ export class Tooltip extends Component {
}

if (typeof value.getTime === 'function') {
return format(value, 'MMM d, yyyy');
return format(value, 'MMM d, yyyy HH:mm:ss');
}

try {
// it's a correct ISO format Date string
if (typeof value === 'string' && (/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}Z/.test(value))) {
return format(Date.parse(value), 'MMM d, yyyy');
return format(Date.parse(value), 'MMM d, yyyy HH:mm:ss');
}
} catch (e){
// not a valid ISO format string
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/model/cartesian-charts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ export class ChartModelCartesian extends ChartModel {
const domainScaleType = cartesianScales.getDomainAxisScaleType();
let domainValueFormatter;
if (domainScaleType === ScaleTypes.TIME) {
domainValueFormatter = (d) => format(d, 'MMM d, yyyy');
domainValueFormatter = (d) => format(d, 'MMM d, yyyy HH:mm:ss');
}

const result = [
[
'Group',
Expand Down