chore: onboard other charts flavors to IBM Telemetry #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
francinelucca
commented
Jan 29, 2024
| @@ -39,7 +39,7 @@ const config: StorybookConfig = { | |||
| // } | |||
| }, | |||
| optimizeDeps: { | |||
| exclude: ['@carbon/telemetry'] | |||
| exclude: ['@ibm/telemetry-js'] | |||
There was a problem hiding this comment.
@theiliad I figured this maybe needed to be updated but not sure what the considerations of this are so just FYI, I can rollback if that's not the case
theiliad
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds config files and dependencies necessary to start tracking telemetry data via IBM Telemetry on
@carbon/charts,@carbon/charts-svelte,@carbon/charts-vue&@carbon/charts-angularUpdates
@carbon/charts,@carbon/charts-svelte,@carbon/charts-vue&@carbon/charts-angular@carbon/telemetrydependency from@carbon/charts,@carbon/charts-svelte,@carbon/charts-vue&@carbon/charts-angular@carbon/charts,@carbon/charts-svelte,@carbon/charts-vue&@carbon/charts-angular@carbon/charts,@carbon/charts-svelte,@carbon/charts-vue&@carbon/charts-angulartelemetry.ymlconfig file to@carbon/charts,@carbon/charts-svelte,@carbon/charts-vue&@carbon/charts-angulartelemetry.ymlin package.json files config of@carbon/charts,@carbon/charts-svelte,@carbon/charts-vueDemo screenshot or recording
N/A