fix(getFillColor):data parameter missing from the arguments #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
theiliad
requested changes
Feb 2, 2024
| @@ -73,7 +72,9 @@ export class StackedArea extends Component { | |||
| originalClassName: 'area' | |||
| }) | |||
| ) | |||
| .style('fill', (d: any) => self.model.getFillColor(getProperty(d, 0, groupMapsTo))) | |||
| .style('fill', (d: any) => | |||
| self.model.getFillColor(getProperty(d, 0, groupMapsTo), undefined, d) | |||
There was a problem hiding this comment.
we shouldn't send undefined over.
Here's an example in scatter.ts
return this.model.getFillColor(d[groupMapsTo], d[domainIdentifier], d)Let's try to send all of that info over pls, and in case we can't locate the data, use null instead of undefined pls
There was a problem hiding this comment.
This applies to all the files in the PR
There was a problem hiding this comment.
https://charts.carbondesignsystem.com/documentation/classes/Chart.html
the charts in this list don't have access to cartesianScale hence I couldn't use getDomainIdentifier with those and some of the charts receive binned and stacked data. I'll be sending null as mentioned.
theiliad
requested changes
Feb 19, 2024
| @@ -216,7 +216,9 @@ export class Area extends Component { | |||
| if (boundsEnabled) { | |||
| enteringAreas | |||
| .attr('fill-opacity', areaConfigs.opacity.selected) | |||
| .style('stroke', (group: any) => self.model.getStrokeColor(group.name)) | |||
| .style('stroke', (group: any) => | |||
| self.model.getStrokeColor(group.name, undefined, group.data) | |||
There was a problem hiding this comment.
Suggested change
| self.model.getStrokeColor(group.name, undefined, group.data) | |
| self.model.getStrokeColor(group.name, null, group.data) |
| @@ -94,7 +94,7 @@ export class Line extends Component { | |||
| originalClassName: 'line' | |||
| }) | |||
| ) | |||
| .style('stroke', (group: any) => this.model.getStrokeColor(group.name)) | |||
| .style('stroke', (group: any) => this.model.getStrokeColor(group.name, undefined, group.data)) | |||
There was a problem hiding this comment.
Suggested change
| .style('stroke', (group: any) => this.model.getStrokeColor(group.name, undefined, group.data)) | |
| .style('stroke', (group: any) => this.model.getStrokeColor(group.name, null, group.data)) |
| @@ -366,9 +367,9 @@ export class Radar extends Component { | |||
| ? () => `translate(${c.x}, ${c.y}) scale(${1 + Math.random() * 0.35})` | |||
| : `translate(${c.x}, ${c.y})` | |||
| ) | |||
| .style('fill', (group: any) => colorScale(group.name)) | |||
| .style('fill', (group: any) => colorScale(group.name, undefined, group.data)) | |||
There was a problem hiding this comment.
Suggested change
| .style('fill', (group: any) => colorScale(group.name, undefined, group.data)) | |
| .style('fill', (group: any) => colorScale(group.name, null, group.data)) |
| .style('fill-opacity', radarConfigs.opacity.selected) | ||
| .style('stroke', (group: any) => colorScale(group.name)) | ||
| .style('stroke', (group: any) => colorScale(group.name, undefined, group.data)) |
There was a problem hiding this comment.
Suggested change
| .style('stroke', (group: any) => colorScale(group.name, undefined, group.data)) | |
| .style('stroke', (group: any) => colorScale(group.name, null, group.data)) |
| @@ -397,8 +398,8 @@ export class Radar extends Component { | |||
| originalClassName: 'blob' | |||
| }) | |||
| ) | |||
| .style('fill', (group: any) => colorScale(group.name)) | |||
| .style('stroke', (group: any) => colorScale(group.name)) | |||
| .style('fill', (group: any) => colorScale(group.name, undefined, group.data)) | |||
There was a problem hiding this comment.
Suggested change
| .style('fill', (group: any) => colorScale(group.name, undefined, group.data)) | |
| .style('fill', (group: any) => colorScale(group.name, null, group.data)) |
| .style('fill', (group: any) => colorScale(group.name)) | ||
| .style('stroke', (group: any) => colorScale(group.name)) | ||
| .style('fill', (group: any) => colorScale(group.name, undefined, group.data)) | ||
| .style('stroke', (group: any) => colorScale(group.name, undefined, group.data)) |
There was a problem hiding this comment.
Suggested change
| .style('stroke', (group: any) => colorScale(group.name, undefined, group.data)) | |
| .style('stroke', (group: any) => colorScale(group.name, null, group.data)) |
theiliad
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates