-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TableExpandHeader): update prop types #18729
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18729 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 408 408
Lines 14645 14645
Branches 4791 4771 -20
=======================================
Hits 12352 12352
- Misses 2131 2132 +1
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! 👍🏼
Closes #18715
Updated
TableExpandHeader
prop types.Changelog
New
deprecated
tag toenableExpando
inTableExpandHeaderPropsWithExpando
since theenableExpando
prop inTableExpandHeaderPropsBase
was being overridden.Removed
ariaLabel
override fromTableExpandHeaderPropsWithToggle
andTableExpandHeaderPropsWithExpando
.Testing / Reviewing
Paste the code from the reproduction at the bottom of packages/react/src/components/DataTable/TableExpandHeader.tsx and check for type errors.
I read through #14386 and I think these changes comply with everything there.