-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ComboBox): update Enter key handling #18737
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18737 +/- ##
==========================================
+ Coverage 84.34% 84.36% +0.02%
==========================================
Files 408 408
Lines 14645 14640 -5
Branches 4771 4821 +50
==========================================
- Hits 12352 12351 -1
+ Misses 2132 2127 -5
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Adam!
Closes #18728
Fixed
ComboBox
Enter key handling.Changelog
Changed
ComboBox
Enter key handling.Testing / Reviewing
yarn test packages/react/src/components/ComboBox
A test story can be created by copying and pasting this code in ComboBox.stories.js:
Reference commits: 448a2b7...3fbba63