chore(tests): add accordion unit tests and snapshots #18780
+242
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennylam
requested review from
2nikhiltom,
guidari,
ariellalgilmore and
annawen1
kennylam
force-pushed
the
chore/wc-accordion-tests
branch
from
aa672d6 to
6e78399
Compare
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18780 +/- ##
=======================================
Coverage 84.28% 84.29%
=======================================
Files 409 409
Lines 14702 14707 +5
Branches 4846 4845 -1
=======================================
+ Hits 12392 12397 +5
- Misses 2146 2157 +11
+ Partials 164 153 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kennylam
force-pushed
the
chore/wc-accordion-tests
branch
from
6e78399 to
dc16db4
Compare
kennylam
force-pushed
the
chore/wc-accordion-tests
branch
from
dc16db4 to
915203d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18779
Update tests to match React
accordion.Changelog
New
Controlledstory to StorybookTesting / Reviewing
Run
yarn testinpackages/web-componentsto make sure tests pass. (From GH CI workflow)