Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete useMergedRefs and use useMergeRefs from floating-ui #18796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamalston
Copy link
Contributor

Closes #17234

Short description

Deleted useMergedRefs and replaced its usages with useMergeRefs from @floating-ui/react.

Changelog

Changed

  • Replaced useMergedRefs usages with useMergeRefs from @floating-ui/react.

Removed

  • Deleted useMergedRefs.

Testing / Reviewing

yarn test packages/react

@adamalston adamalston requested review from a team as code owners March 9, 2025 22:00
Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 1f0b7db
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67ce0f656eab0e0008097b79
😎 Deploy Preview https://deploy-preview-18796--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1f0b7db
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67ce0f65449a24000840df10
😎 Deploy Preview https://deploy-preview-18796--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f0b7db
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67ce0f65060ae00008c3b80d
😎 Deploy Preview https://deploy-preview-18796--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (fe90ac8) to head (1f0b7db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18796   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files         409      409           
  Lines       14707    14707           
  Branches     4794     4845   +51     
=======================================
  Hits        12397    12397           
+ Misses       2157     2155    -2     
- Partials      153      155    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate and consolidate useMergedRefs helpers
1 participant