wip updating tests

Author: burieberry

packages/host/app/components/operator-mode/code-submode.gts

@@ -756,7 +756,7 @@ export default class CodeSubmode extends Component<Signature> {
     return selection ?? 'schema-editor';
   }
 
-  @action private openAccordionItem(item: SelectedAccordionItem) {
+  @action private toggleAccordionItem(item: SelectedAccordionItem) {
     if (this.selectedAccordionItem === item) {
       let index = accordionItems.indexOf(item);
       if (index !== -1 && index === accordionItems.length - 1) {
@@ -983,7 +983,10 @@ export default class CodeSubmode extends Component<Signature> {
                         <A.Item
                           class='accordion-item'
                           @contentClass='accordion-item-content'
-                          @onClick={{fn this.openAccordionItem 'schema-editor'}}
+                          @onClick={{fn
+                            this.toggleAccordionItem
+                            'schema-editor'
+                          }}
                           @isOpen={{eq
                             this.selectedAccordionItem
                             'schema-editor'
@@ -1001,7 +1004,7 @@ export default class CodeSubmode extends Component<Signature> {
                       <A.Item
                         class='accordion-item'
                         @contentClass='accordion-item-content'
-                        @onClick={{fn this.openAccordionItem 'playground'}}
+                        @onClick={{fn this.toggleAccordionItem 'playground'}}
                         @isOpen={{eq this.selectedAccordionItem 'playground'}}
                         data-test-accordion-item='playground'
                       >
@@ -1042,13 +1045,20 @@ export default class CodeSubmode extends Component<Signature> {
                       <SpecPreview
                         @selectedDeclaration={{this.selectedDeclaration}}
                         @isLoadingNewModule={{this.moduleContentsResource.isLoadingNewModule}}
-                        @openAccordionItem={{this.openAccordionItem}}
+                        @toggleAccordionItem={{this.toggleAccordionItem}}
+                        @isPanelOpen={{eq
+                          this.selectedAccordionItem
+                          'spec-preview'
+                        }}
                         as |SpecPreviewTitle SpecPreviewContent|
                       >
                         <A.Item
                           class='accordion-item'
                           @contentClass='accordion-item-content'
-                          @onClick={{fn this.openAccordionItem 'spec-preview'}}
+                          @onClick={{fn
+                            this.toggleAccordionItem
+                            'spec-preview'
+                          }}
                           @isOpen={{eq
                             this.selectedAccordionItem
                             'spec-preview'

packages/host/app/components/operator-mode/code-submode/spec-preview.gts

@@ -86,7 +86,8 @@ interface Signature {
   Args: {
     selectedDeclaration?: ModuleDeclaration;
     isLoadingNewModule: boolean;
-    openAccordionItem: (item: SelectedAccordionItem) => void;
+    toggleAccordionItem: (item: SelectedAccordionItem) => void;
+    isPanelOpen: boolean;
   };
   Blocks: {
     default: [
@@ -494,7 +495,9 @@ export default class SpecPreview extends GlimmerComponent<Signature> {
         await this.cardService.saveModel(card);
         if (card.id) {
           this.specPanelService.setSelection(card.id);
-          this.args.openAccordionItem('spec-preview');
+          if (!this.args.isPanelOpen) {
+            this.args.toggleAccordionItem('spec-preview');
+          }
         }
       } catch (e: any) {
         console.log('Error saving', e);
@@ -698,7 +701,7 @@ export default class SpecPreview extends GlimmerComponent<Signature> {
     const fileUrl = id.endsWith('.json') ? id : `${id}.json`;
     this.recentFilesService.addRecentFileUrl(fileUrl);
     this.updatePlaygroundSelections(id);
-    this.args.openAccordionItem('playground');
+    this.args.toggleAccordionItem('playground');
   };
 
   <template>

packages/host/tests/acceptance/code-submode/spec-test.gts

@@ -571,9 +571,10 @@ module('Acceptance | Spec preview', function (hooks) {
       submode: 'code',
       codePath: `${testRealmURL}new-skill.gts`,
     });
-    await waitFor('[data-test-accordion-item="spec-preview"]');
     assert.dom('[data-test-accordion-item="spec-preview"]').exists();
     assert.dom('[data-test-create-spec-button]').exists();
+    assert.dom('[data-test-create-spec-intent-message]').doesNotExist();
+    await click('[data-test-accordion-item="spec-preview"] button');
     assert.dom('[data-test-create-spec-intent-message]').exists();
     await percySnapshot(assert);
   });
@@ -610,12 +611,9 @@ module('Acceptance | Spec preview', function (hooks) {
       codePath: `${testRealmURL}person-1.gts`,
     });
     assert.dom('[data-test-create-spec-button]').exists();
-    await click('[data-test-accordion-item="spec-preview"] button');
     await click('[data-test-create-spec-button]');
     //spec is opened
-    await assert
-      .dom('[data-test-accordion-item="spec-preview"]')
-      .hasClass('open');
+    assert.dom('[data-test-accordion-item="spec-preview"]').hasClass('open');
     assert.dom('[data-test-title] [data-test-boxel-input]').hasValue('Person1');
     assert.dom('[data-test-exported-type]').hasText('card');
     assert.dom('[data-test-exported-name]').hasText('Person1');