Skip to content

Commit 177a32f

Browse files
FadhlanRFadhlanR
authored
Push latest version of eslint-plugin-ember (#1292)
1 parent 9510549 commit 177a32f

File tree

7 files changed

+402
-111
lines changed

7 files changed

+402
-111
lines changed

‎packages/host/.eslintrc.js

+88-42
Original file line numberDiff line numberDiff line change
@@ -2,43 +2,98 @@
22

33
module.exports = {
44
root: true,
5-
parser: '@typescript-eslint/parser',
6-
parserOptions: {
7-
ecmaVersion: 'latest',
8-
sourceType: 'module',
9-
requireConfigFile: false,
10-
babelOptions: {
11-
plugins: [
12-
['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],
13-
],
14-
},
15-
},
16-
plugins: ['ember', '@typescript-eslint'],
17-
extends: [
18-
'eslint:recommended',
19-
'plugin:ember/recommended',
20-
'plugin:@typescript-eslint/recommended',
21-
'plugin:prettier/recommended',
22-
'plugin:qunit-dom/recommended',
23-
],
245
env: {
256
browser: true,
267
},
27-
rules: {
28-
'@typescript-eslint/no-empty-function': 'off',
29-
'@typescript-eslint/no-unused-vars': [
30-
'error',
31-
{ argsIgnorePattern: '^_', varsIgnorePattern: '^_' },
32-
],
33-
'prefer-const': 'off',
34-
'@typescript-eslint/no-explicit-any': 'off',
35-
'@typescript-eslint/ban-types': 'off',
36-
'@typescript-eslint/ban-ts-comment': 'off',
37-
'@typescript-eslint/explicit-module-boundary-types': 'off',
38-
'@typescript-eslint/no-this-alias': 'off',
39-
'@typescript-eslint/no-non-null-assertion': 'off',
40-
},
418
overrides: [
9+
{
10+
files: ['**/*.{js,ts}'],
11+
parser: '@typescript-eslint/parser',
12+
parserOptions: {
13+
ecmaVersion: 'latest',
14+
sourceType: 'module',
15+
requireConfigFile: false,
16+
babelOptions: {
17+
plugins: [
18+
[
19+
'@babel/plugin-proposal-decorators',
20+
{ decoratorsBeforeExport: true },
21+
],
22+
],
23+
},
24+
},
25+
plugins: ['ember', '@typescript-eslint'],
26+
extends: [
27+
'eslint:recommended',
28+
'plugin:ember/recommended',
29+
'plugin:@typescript-eslint/recommended',
30+
'plugin:prettier/recommended',
31+
'plugin:qunit-dom/recommended',
32+
],
33+
rules: {
34+
'@typescript-eslint/no-empty-function': 'off',
35+
'@typescript-eslint/no-unused-vars': [
36+
'error',
37+
{ argsIgnorePattern: '^_', varsIgnorePattern: '^_' },
38+
],
39+
'prefer-const': 'off',
40+
'@typescript-eslint/no-explicit-any': 'off',
41+
'@typescript-eslint/ban-types': 'off',
42+
'@typescript-eslint/ban-ts-comment': 'off',
43+
'@typescript-eslint/explicit-module-boundary-types': 'off',
44+
'@typescript-eslint/no-this-alias': 'off',
45+
'@typescript-eslint/no-non-null-assertion': 'off',
46+
'no-undef': 'off',
47+
'ember/no-runloop': 'off',
48+
},
49+
},
50+
{
51+
files: ['**/*.gts'],
52+
parser: 'ember-eslint-parser',
53+
parserOptions: {
54+
ecmaVersion: 'latest',
55+
sourceType: 'module',
56+
requireConfigFile: false,
57+
babelOptions: {
58+
plugins: [
59+
[
60+
'@babel/plugin-proposal-decorators',
61+
{ decoratorsBeforeExport: true },
62+
],
63+
],
64+
},
65+
warnOnUnsupportedTypeScriptVersion: false,
66+
},
67+
plugins: ['ember'],
68+
extends: [
69+
'eslint:recommended',
70+
'plugin:@typescript-eslint/recommended',
71+
'plugin:ember/recommended',
72+
'plugin:ember/recommended-gts',
73+
'plugin:prettier/recommended',
74+
'plugin:qunit-dom/recommended',
75+
],
76+
rules: {
77+
'@typescript-eslint/no-empty-function': 'off',
78+
'@typescript-eslint/no-unused-vars': [
79+
'error',
80+
{ argsIgnorePattern: '^_', varsIgnorePattern: '^_' },
81+
],
82+
'prefer-const': 'off',
83+
'@typescript-eslint/no-explicit-any': 'off',
84+
'@typescript-eslint/ban-types': 'off',
85+
'@typescript-eslint/ban-ts-comment': 'off',
86+
'@typescript-eslint/explicit-module-boundary-types': 'off',
87+
'@typescript-eslint/no-this-alias': 'off',
88+
'@typescript-eslint/no-non-null-assertion': 'off',
89+
'no-undef': 'off',
90+
'ember/template-no-let-reference': 'off',
91+
'ember/no-tracked-properties-from-args': 'off',
92+
'ember/no-runloop': 'off',
93+
'node/no-deprecated-api': 'off',
94+
'deprecation/deprecation': 'off',
95+
},
96+
},
4297
// node files
4398
{
4499
files: [
@@ -75,15 +130,6 @@ module.exports = {
75130
'qunit/no-conditional-assertions': 'off',
76131
},
77132
},
78-
{
79-
// typescript-eslint recommends turning off no-undef for Typescript files since
80-
// Typescript will better analyse that:
81-
// https://github.com/typescript-eslint/typescript-eslint/blob/5b0e577f2552e8b2c53a3fb22edc9d219589b937/docs/linting/Troubleshooting.mdx#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
82-
files: ['**/*.ts', '**/*.gts'],
83-
rules: {
84-
'no-undef': 'off',
85-
},
86-
},
87133
{
88134
// don’t enforce import order on blueprint files
89135
files: ['app/**', 'tests/**'],

‎packages/host/app/components/ai-assistant/chat-input/usage.gts

+5-5
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ export default class AiAssistantChatInputUsage extends Component {
2525
<template>
2626
<FreestyleUsage @name='AiAssistant::ChatInput'>
2727
<:description>
28-
Chat input field for AI Assistant is a \`BoxelInput\` component of type
28+
Chat input field for AI Assistant is a 'BoxelInput' component of type
2929
'textarea' with a send button. This component accepts all arguments that
30-
are accepted by \`BoxelInput\` component in addition to an \`onSend\`
30+
are accepted by 'BoxelInput' component in addition to an 'onSend'
3131
argument for action to take when message is submitted. A message can be
32-
submitted via pressing \`cmd+Enter\` or \`ctrl+Enter\` keys or by
33-
clicking on the send button.
32+
submitted via pressing 'cmd+Enter' or 'ctrl+Enter' keys or by clicking
33+
on the send button.
3434
</:description>
3535
<:example>
3636
<AiAssistantChatInput
@@ -53,7 +53,7 @@ export default class AiAssistantChatInputUsage extends Component {
5353
/>
5454
<Args.Action
5555
@name='onSend'
56-
@description='Action to be called when "cmd+Enter" or \`ctrl+Enter\` keys are pressed or send button is clicked'
56+
@description='Action to be called when "cmd+Enter" or "ctrl+Enter" keys are pressed or send button is clicked'
5757
@value={{this.onSend}}
5858
/>
5959
<Args.Bool

‎packages/host/app/components/operator-mode/interact-submode.gts

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ const clearSelections = new WeakMap<StackItem, () => void>();
6464
const stackItemScrollers = new WeakMap<
6565
StackItem,
6666
{
67-
stableScroll: (changeSizeCallback: () => Promise<void>) => void;
68-
scrollIntoView: (selector: string) => void;
67+
stableScroll: (_changeSizeCallback: () => Promise<void>) => void;
68+
scrollIntoView: (_selector: string) => void;
6969
}
7070
>();
7171

‎packages/host/app/components/operator-mode/syntax-error-display.gts

+3-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ export default class SyntaxErrorDisplay extends Component<Signature> {
4949
</div>
5050

5151
<hr />
52-
<pre data-test-syntax-errors>{{this.removeSourceMappingURL @syntaxErrors}}</pre>
52+
<pre data-test-syntax-errors>{{this.removeSourceMappingURL
53+
@syntaxErrors
54+
}}</pre>
5355
</div>
5456
</div>
5557
</template>

‎packages/host/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@
7070
"@types/qunit": "^2.11.3",
7171
"@types/rsvp": "^4.0.9",
7272
"@types/uuid": "^9.0.8",
73-
"@typescript-eslint/eslint-plugin": "^5.17.0",
74-
"@typescript-eslint/parser": "^5.17.0",
73+
"@typescript-eslint/eslint-plugin": "^7.9.0",
74+
"@typescript-eslint/parser": "^7.9.0",
7575
"broccoli-asset-rev": "^3.0.0",
7676
"broccoli-merge-trees": "^4.2.0",
7777
"broccoli-plugin": "^4.0.7",
@@ -128,7 +128,7 @@
128128
"ember-window-mock": "^0.9.0",
129129
"eslint": "^8.52.0",
130130
"eslint-config-prettier": "^9.0.0",
131-
"eslint-plugin-ember": "^11.11.1",
131+
"eslint-plugin-ember": "^12.1.1",
132132
"eslint-plugin-import": "^2.28.1",
133133
"eslint-plugin-n": "^16.2.0",
134134
"eslint-plugin-prettier": "^5.0.1",

‎packages/host/tests/integration/components/card-basics-test.gts

+1-1
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@ module('Integration | card-basics', function (hooks) {
615615
await renderCard(loader, driver, 'edit');
616616
assert.dom('input').doesNotExist('no input fields exist');
617617
assert
618-
.dom('[data-test-ref')
618+
.dom('[data-test-ref]')
619619
.containsText(`Module: http://localhost:4202/test/person Name: Person`);
620620
});
621621

0 commit comments

Comments
 (0)