Make defaultFormat the last argument of getBoxComponent

Author: lukemelia

packages/base/card-api.gts

@@ -1465,7 +1465,7 @@ function fieldComponent(
       (model.value[fieldName]?.constructor as typeof BaseDef) ?? field.card;
   }
   let innerModel = model.field(fieldName) as unknown as Box<BaseDef>;
-  return getBoxComponent(card, defaultFormat, innerModel, field);
+  return getBoxComponent(card, innerModel, field, defaultFormat);
 }
 
 // our decorators are implemented by Babel, not TypeScript, so they have a
@@ -2720,9 +2720,9 @@ export function getComponent(
   let box = Box.create(model);
   let boxComponent = getBoxComponent(
     model.constructor as BaseDefConstructor,
-    format,
     box,
     field,
+    format,
   );
   return boxComponent;
 }

packages/base/field-component.gts

@@ -62,9 +62,9 @@ const componentCache = initSharedState(
 
 export function getBoxComponent(
   card: typeof BaseDef,
-  defaultFormat: Format,
   model: Box<BaseDef>,
   field: Field | undefined,
+  defaultFormat: Format,
 ): BoxComponent {
   let stable = componentCache.get(model);
   if (stable) {
@@ -320,7 +320,7 @@ export function getPluralViewComponent(
 ): BoxComponent {
   let getComponents = () =>
     model.children.map((child) =>
-      getBoxComponent(cardTypeFor(field, child), format, child, field),
+      getBoxComponent(cardTypeFor(field, child), child, field, format),
     ); // Wrap the the components in a function so that the template is reactive to changes in the model (this is essentially a helper)
   let pluralViewComponent: TemplateOnlyComponent<BoxComponentSignature> =
     <template>

packages/base/links-to-editor.gts

@@ -111,9 +111,9 @@ class LinksToEditor extends GlimmerComponent<Signature> {
       .constructor as typeof BaseDef;
     return getBoxComponent(
       card,
-      'embedded',
       this.args.model as Box<BaseDef>,
       this.args.field,
+      'embedded',
     );
   }
 

packages/base/links-to-many-component.gts

@@ -53,9 +53,9 @@ class LinksToManyEditor extends GlimmerComponent<Signature> {
                 {{#let
                   (getBoxComponent
                     (this.args.cardTypeFor @field boxedElement)
-                    'embedded'
                     boxedElement
                     @field
+                    'embedded'
                   )
                   as |Item|
                 }}
@@ -93,9 +93,9 @@ class LinksToManyEditor extends GlimmerComponent<Signature> {
             {{#let
               (getBoxComponent
                 (this.args.cardTypeFor @field boxedElement)
-                'atom'
                 boxedElement
                 @field
+                'atom'
               )
               as |Item|
             }}