fix proxy in fieldsComponnetsFor

Author: tintinthong

packages/base/field-component.gts

@@ -420,6 +420,15 @@ function fieldsComponentsFor<T extends BaseDef>(
       }
       let field = maybeField;
 
+      if (
+        field.fieldType === 'linksToMany' ||
+        field.fieldType === 'containsMany'
+      ) {
+        let stable = stableComponents.get(property);
+        if (stable) {
+          return stable;
+        }
+      }
       let result = field.component(model as unknown as Box<BaseDef>);
       stableComponents.set(property, result);
       return result;

packages/base/links-to-many-component.gts

@@ -465,22 +465,11 @@ export function getLinksToManyComponent({
       </style>
     </template>
   };
-  let stableComponents = new Map<string, BoxComponent[]>();
   return new Proxy(linksToManyComponent, {
     get(target, property, received) {
       // proxying the bare minimum of an Array in order to render within a
       // template. add more getters as necessary...
-
-      //we need stable components to ensure the modifier remains on the linksToManyComponent and doesn't get recreated
-      //test would break otherwise but the expected behavior still works in the app (this has to do with the sortable modifier readiness when the component is torn down)
-      //we previously had a stable component cache in the proxy but removed it since we believe it is not needed
-      //in order to fix test, I have moved a cache here since this seems like the only place it is affected
-      //TODO: meet with ed to iron out this cache
-      let components = stableComponents.get(property);
-      if (!components) {
-        components = getComponents();
-        stableComponents.set(property, components);
-      }
+      let components = getComponents();
 
       if (property === Symbol.iterator) {
         return components[Symbol.iterator];