Apply code review feedback

Author: lukemelia

packages/base/code-ref.gts

@@ -16,6 +16,14 @@ import {
 import { ResolvedCodeRef } from '@cardstack/runtime-common';
 import CodeIcon from '@cardstack/boxel-icons/code';
 
+function moduleIsUrlLike(module: string) {
+  return (
+    module.startsWith('http') ||
+    module.startsWith('.') ||
+    module.startsWith('/')
+  );
+}
+
 class BaseView extends Component<typeof CodeRefField> {
   <template>
     <div data-test-ref>
@@ -37,11 +45,11 @@ export default class CodeRefField extends FieldDef {
     _visited?: Set<string>,
     opts?: SerializeOpts,
   ) {
-    const moduleIsUrlLike =
-      codeRef.module.startsWith('http') || codeRef.module.startsWith('.');
     return {
       ...codeRef,
-      ...(opts?.maybeRelativeURL && !opts?.useAbsoluteURL && moduleIsUrlLike
+      ...(opts?.maybeRelativeURL &&
+      !opts?.useAbsoluteURL &&
+      moduleIsUrlLike(codeRef.module)
         ? { module: opts.maybeRelativeURL(codeRef.module) }
         : {}),
     };
@@ -72,9 +80,7 @@ function maybeSerializeCodeRef(
   stack: CardDef[] = [],
 ) {
   if (codeRef) {
-    const moduleIsUrlLike =
-      codeRef.module.startsWith('http') || codeRef.module.startsWith('.');
-    if (moduleIsUrlLike) {
+    if (moduleIsUrlLike(codeRef.module)) {
       // if a stack is passed in, use the containing card to resolve relative references
       let moduleHref =
         stack.length > 0

packages/base/skill-card.gts

@@ -11,22 +11,13 @@ import CodeRefField from './code-ref';
 import MarkdownField from './markdown';
 import StringField from './string';
 import RobotIcon from '@cardstack/boxel-icons/robot';
-
-function djb2_xor(str: string) {
-  let len = str.length;
-  let h = 5381;
-
-  for (let i = 0; i < len; i++) {
-    h = (h * 33) ^ str.charCodeAt(i);
-  }
-  return (h >>> 0).toString(16);
-}
+import { simpleHash } from '@cardstack/runtime-common';
 
 function friendlyModuleName(fullModuleUrl: string) {
   return fullModuleUrl
     .split('/')
-    .slice(-1)[0]
-    .replace(/\.gts$/, ' ');
+    .pop()!
+    .replace(/\.gts$/, '');
 }
 
 export class CommandField extends FieldDef {
@@ -46,7 +37,7 @@ export class CommandField extends FieldDef {
         return '';
       }
 
-      const hashed = djb2_xor(`${this.codeRef.module}#${this.codeRef.name}`);
+      const hashed = simpleHash(`${this.codeRef.module}#${this.codeRef.name}`);
       let name =
         this.codeRef.name === 'default'
           ? friendlyModuleName(this.codeRef.module)