add create card instance command

Author: burieberry

Diff for: packages/base/command.gts

@@ -58,6 +58,7 @@ export class WriteTextFileInput extends CardDef {
 }
 
 export class CreateInstanceInput extends CardDef {
+  @field parent = contains(JsonField);
   @field module = contains(CodeRefField);
   @field realm = contains(StringField);
 }

Diff for: packages/host/app/commands/create-card-json.ts renamed to packages/host/app/commands/create-card-instance.ts

@@ -1,13 +1,17 @@
 import { type LooseSingleCardDocument } from '@cardstack/runtime-common';
 
+import { getCard } from '@cardstack/host/resources/card-resource';
+
+import type { CardDef } from 'https://cardstack.com/base/card-api';
 import type * as BaseCommandModule from 'https://cardstack.com/base/command';
 
 import HostBaseCommand from '../lib/host-base-command';
 
-export default class CreateCardJsonCommand extends HostBaseCommand<
-  typeof BaseCommandModule.CreateInstanceInput
+export default class CreateCardInstanceCommand extends HostBaseCommand<
+  typeof BaseCommandModule.CreateInstanceInput,
+  typeof CardDef | undefined
 > {
-  description = `Create a new card json document given a card ref and realm.`;
+  description = `Create a new card instance given a card ref and realm.`;
 
   async getInputType() {
     let commandModule = await this.loadCommandModule();
@@ -17,8 +21,8 @@ export default class CreateCardJsonCommand extends HostBaseCommand<
 
   protected async run(
     input: BaseCommandModule.CreateInstanceInput,
-  ): Promise<LooseSingleCardDocument> {
-    if (!input.module || !input.realm) {
+  ): Promise<CardDef | undefined> {
+    if (!input.parent || !input.module || !input.realm) {
       throw new Error(
         "Create instance command can't run because it doesn't have all the fields in arguments returned by open ai",
       );
@@ -31,6 +35,10 @@ export default class CreateCardJsonCommand extends HostBaseCommand<
         },
       },
     };
-    return doc;
+    let cardResource = getCard(input.parent, () => doc, {
+      isAutoSave: () => true,
+    });
+    await cardResource.loaded; // this await should not be necessary when card-resource is refactored
+    return cardResource.card;
   }
 }

Diff for: packages/host/app/commands/index.ts

@@ -3,8 +3,8 @@ import { VirtualNetwork } from '@cardstack/runtime-common';
 import * as AddFieldToCardDefinitionCommandModule from './add-field-to-card-definition';
 import * as AddSkillsToRoomCommandModule from './add-skills-to-room';
 import * as CopyCardCommandModule from './copy-card';
-import * as CreateCardJsonCommandModule from './create-card-json';
 import * as CreateAIAssistantRoomCommandModule from './create-ai-assistant-room';
+import * as CreateCardInstanceCommandModule from './create-card-instance';
 import * as OpenAiAssistantRoomCommandModule from './open-ai-assistant-room';
 import * as PatchCardCommandModule from './patch-card';
 import * as ReloadCardCommandModule from './reload-card';
@@ -31,8 +31,8 @@ export function shimHostCommands(virtualNetwork: VirtualNetwork) {
     CopyCardCommandModule,
   );
   virtualNetwork.shimModule(
-    '@cardstack/boxel-host/commands/create-card-json',
-    CreateCardJsonCommandModule,
+    '@cardstack/boxel-host/commands/create-card-instance',
+    CreateCardInstanceCommandModule,
   );
   virtualNetwork.shimModule(
     '@cardstack/boxel-host/commands/create-ai-assistant-room',

Diff for: packages/host/app/components/operator-mode/code-submode/playground-panel.gts

@@ -4,7 +4,6 @@ import { action } from '@ember/object';
 import type Owner from '@ember/owner';
 import { service } from '@ember/service';
 import Component from '@glimmer/component';
-import { tracked } from '@glimmer/tracking';
 
 import Folder from '@cardstack/boxel-icons/folder';
 import { task } from 'ember-concurrency';
@@ -31,11 +30,10 @@ import {
   cardTypeIcon,
   chooseCard,
   type Query,
-  type LooseSingleCardDocument,
   type ResolvedCodeRef,
 } from '@cardstack/runtime-common';
 
-import CreateCardJsonCommand from '@cardstack/host/commands/create-card-json';
+import CreateCardInstanceCommand from '@cardstack/host/commands/create-card-instance';
 
 import { getCard } from '@cardstack/host/resources/card-resource';
 import { getCodeRef, type CardType } from '@cardstack/host/resources/card-type';
@@ -382,7 +380,6 @@ class PlaygroundPanelContent extends Component<PlaygroundContentSignature> {
   @service private declare realm: RealmService;
   @service private declare realmServer: RealmServerService;
   @service declare recentFilesService: RecentFilesService;
-  @tracked newCardJSON: LooseSingleCardDocument | undefined;
   private playgroundSelections: Record<
     string, // moduleId
     { cardId: string; format: Format }
@@ -435,8 +432,7 @@ class PlaygroundPanelContent extends Component<PlaygroundContentSignature> {
 
   private cardResource = getCard(
     this,
-    () =>
-      this.newCardJSON ?? this.playgroundSelections[this.args.moduleId]?.cardId,
+    () => this.playgroundSelections[this.args.moduleId]?.cardId,
     { isAutoSave: () => true },
   );
 
@@ -483,7 +479,6 @@ class PlaygroundPanelContent extends Component<PlaygroundContentSignature> {
   }
 
   private persistSelections = (cardId: string, format = this.format) => {
-    this.newCardJSON = undefined;
     this.playgroundSelections[this.args.moduleId] = { cardId, format };
     window.localStorage.setItem(
       PlaygroundSelections,
@@ -514,17 +509,16 @@ class PlaygroundPanelContent extends Component<PlaygroundContentSignature> {
     }
   });
 
-  // TODO: convert this to @action once we no longer need to await below
   private createNew = task(async () => {
     let { commandContext } = this.commandService;
-    this.newCardJSON = await new CreateCardJsonCommand(commandContext).execute({
+    let card = await new CreateCardInstanceCommand(commandContext).execute({
+      parent: this,
       module: this.args.codeRef,
       realm: this.operatorModeStateService.realmURL.href,
     });
-    await this.cardResource.loaded; // TODO: remove await when card-resource is refactored
-    if (this.card) {
-      this.recentFilesService.addRecentFileUrl(`${this.card.id}.json`);
-      this.persistSelections(this.card.id, 'edit'); // open new instance in playground in edit format
+    if (card) {
+      this.recentFilesService.addRecentFileUrl(`${card.id}.json`);
+      this.persistSelections(card.id, 'edit'); // open new instance in playground in edit format
     }
   });