cleanup based on review

Author: habdelra

packages/host/config/environment.js

@@ -108,7 +108,8 @@ function getLatestSchemaFile() {
   let files = fs.readdirSync(schemaDir);
   let latestSchemaFile = files.sort().pop();
   if (
-    lastMigration.replace(/_.*/, '') !== latestSchemaFile.replace(/_.*/, '')
+    lastMigration.replace(/_.*/, '') !== latestSchemaFile.replace(/_.*/, '') &&
+    ['development', 'test'].includes(process.env.EMBER_ENV)
   ) {
     throw new Error(
       `The sqlite schema file is out of date--please regenerate the sqlite schema file`,

packages/realm-server/scripts/convert-to-sqlite.ts

@@ -30,10 +30,6 @@ let pgDump = readFileSync(pgDumpFile, 'utf8');
 
 let cst = parse(prepareDump(pgDump), {
   dialect: 'postgresql',
-  includeSpaces: true,
-  includeNewlines: true,
-  includeComments: true,
-  includeRange: true,
 });
 
 let sql: string[] = [
@@ -122,10 +118,14 @@ function createColumns(
 
     columns.push(column.join(' '));
   }
-  sql.push([...columns, makePrimaryKeyConstraint(cst, tableName)].join(',\n'));
+  let pkConstraint = makePrimaryKeyConstraint(cst, tableName);
+  sql.push([...columns, ...(pkConstraint ? [pkConstraint] : [])].join(',\n'));
 }
 
-function makePrimaryKeyConstraint(cst: Program, tableName: string): string {
+function makePrimaryKeyConstraint(
+  cst: Program,
+  tableName: string,
+): string | undefined {
   let alterTableStmts = cst.statements.filter(
     (s) =>
       s.type === 'alter_table_stmt' &&
@@ -180,6 +180,9 @@ function makePrimaryKeyConstraint(cst: Program, tableName: string): string {
       }
     }
   }
+  if (pkConstraint.length === 0) {
+    return undefined;
+  }
   return pkConstraint.join(' ');
 }