Merge pull request #2177 from cardstack/investigate-link-id

Allow to search null field on search resources / improve parse query on null handling

Author: richardhjtan

packages/host/app/components/prerendered-card-search.gts

@@ -133,11 +133,14 @@ export default class PrerenderedCardSearch extends Component<Signature> {
     realmURL: string,
   ): Promise<PrerenderedCard[]> {
     let json = (await this.cardService.fetchJSON(
-      `${realmURL}_search-prerendered?${stringify({
-        ...query,
-        prerenderedHtmlFormat: format,
-        cardUrls,
-      })}`,
+      `${realmURL}_search-prerendered?${stringify(
+        {
+          ...query,
+          prerenderedHtmlFormat: format,
+          cardUrls,
+        },
+        { strictNullHandling: true },
+      )}`,
     )) as unknown as PrerenderedCardCollectionDocument;
     if (!isPrerenderedCardCollectionDocument(json)) {
       throw new Error(

packages/host/app/resources/search.ts

@@ -168,7 +168,9 @@ export class Search extends Resource<Args> {
         await Promise.all(
           this.realmsToSearch.map(async (realm) => {
             let json = await this.cardService.fetchJSON(
-              `${realm}_search?${stringify(query)}`,
+              `${realm}_search?${stringify(query, {
+                strictNullHandling: true,
+              })}`,
             );
             if (!isCardCollectionDocument(json)) {
               throw new Error(

packages/host/tests/integration/realm-indexing-and-querying-test.gts

@@ -4391,6 +4391,22 @@ posts/ignore-me.json
       );
     });
 
+    test(`can use 'eq' to find empty linksTo field`, async function (assert) {
+      let { data: matching } = await queryEngine.search({
+        filter: {
+          on: {
+            module: `${testModuleRealm}friend`,
+            name: 'Friend',
+          },
+          every: [{ eq: { firstName: 'Mango' } }, { eq: { friend: null } }],
+        },
+      });
+      assert.deepEqual(
+        matching.map((m) => m.id),
+        [`${testRealmURL}friend2`],
+      );
+    });
+
     test(`can search for cards by using a computed field`, async function (assert) {
       let { data: matching } = await queryEngine.search({
         filter: {

packages/runtime-common/query.ts

@@ -110,7 +110,7 @@ export function isAnyFilter(filter: Filter): filter is AnyFilter {
 }
 
 export function buildQueryString(query: Query): string {
-  return `?${qs.stringify(query)}`;
+  return `?${qs.stringify(query, { strictNullHandling: true })}`;
 }
 
 export function assertQuery(
@@ -431,5 +431,9 @@ export function assertKey(key: string, pointer: string[]) {
 }
 
 export const parseQuery = (queryString: string) => {
-  return qs.parse(queryString, { depth: 10, strictDepth: true });
+  return qs.parse(queryString, {
+    depth: 10,
+    strictDepth: true,
+    strictNullHandling: true,
+  });
 };