Merge pull request #2206 from cardstack/matrix-helpers-for-loop

Use a for loop instead of map with async in matrix helper

Author: lukemelia

packages/matrix/helpers/index.ts

@@ -77,11 +77,8 @@ export async function openAiAssistant(page: Page) {
     document.querySelector('[data-test-close-ai-assistant]'),
   );
 
-  await page.waitForFunction(
-    () =>
-      document
-        .querySelector('[data-test-room]')
-        ?.getAttribute('data-test-room'),
+  await page.waitForFunction(() =>
+    document.querySelector('[data-test-room]')?.getAttribute('data-test-room'),
   ); // Opening the AI assistant either opens last room or creates one - wait for it to settle
 }
 
@@ -492,7 +489,7 @@ export async function assertMessages(
           `[data-test-message-idx="${index}"] [data-test-attached-card]`,
         ),
       ).toHaveCount(cards.length);
-      cards.map(async (card) => {
+      for (let card of cards) {
         if (card.title) {
           if (message != null && card.title.includes(message)) {
             throw new Error(
@@ -514,7 +511,7 @@ export async function assertMessages(
             ),
           ).toHaveCount(1);
         }
-      });
+      }
     }
 
     if (files?.length) {
@@ -524,13 +521,16 @@ export async function assertMessages(
         ),
       ).toHaveCount(1);
       await expect(
-            page.locator(`[data-test-message-idx="${index}"] [data-test-attached-file]`)).toHaveCount(files.length)
+        page.locator(
+          `[data-test-message-idx="${index}"] [data-test-attached-file]`,
+        ),
+      ).toHaveCount(files.length);
       files.map(async (file) => {
-          await expect(
-            page.locator(
-              `[data-test-message-idx="${index}"] [data-test-attached-file="${file.sourceUrl}"]`,
-            ),
-          ).toContainText(file.name);  
+        await expect(
+          page.locator(
+            `[data-test-message-idx="${index}"] [data-test-attached-file="${file.sourceUrl}"]`,
+          ),
+        ).toContainText(file.name);
       });
     }