Merge pull request #1114 from cardstack/remove-streaming-indicator-for-errors-and-options

Do not show bot streaming message indicator when it sends an error or an apply option

Author: jurgenwerk

packages/ai-bot/main.ts

@@ -104,6 +104,7 @@ async function sendOption(
     msgtype: 'org.boxel.command',
     formatted_body: body,
     format: 'org.matrix.custom.html',
+    isStreamingFinished: true,
     data: {
       command: {
         type: 'patch',
@@ -159,6 +160,9 @@ async function sendError(
       room,
       'There was an error processing your request, please try again later',
       eventToUpdate,
+      {
+        isStreamingFinished: true,
+      },
     );
   } catch (e) {
     // We've had a problem sending the error message back to the user

packages/base/room.gts

@@ -520,6 +520,7 @@ export class RoomField extends FieldDef {
               commandType: command.type,
               payload: command,
             }),
+            isStreamingFinished: true,
           });
         } else {
           // Text from the AI bot

packages/host/tests/integration/components/operator-mode-test.gts

@@ -1213,6 +1213,51 @@ module('Integration | operator-mode', function (hooks) {
           'Answer to my last question is not in progress',
         );
     });
+
+    test('it does not display the streaming indicator when ai bot sends an option', async function (assert) {
+      await setCardInOperatorModeState();
+      await renderComponent(
+        class TestDriver extends GlimmerComponent {
+          <template>
+            <OperatorMode @onClose={{noop}} />
+            <CardPrerender />
+          </template>
+        },
+      );
+      let roomId = await openAiAssistant();
+
+      addRoomEvent(matrixService, {
+        event_id: 'event1',
+        room_id: roomId,
+        state_key: 'state',
+        type: 'm.room.message',
+        origin_server_ts: new Date(2024, 0, 3, 12, 30).getTime(),
+        sender: '@aibot:localhost',
+        content: {
+          body: 'i am the body',
+          msgtype: 'org.boxel.command',
+          formatted_body: 'A patch',
+          format: 'org.matrix.custom.html',
+          data: JSON.stringify({
+            command: {
+              type: 'patch',
+              id: `${testRealmURL}Person/fadhlan`,
+              patch: {
+                attributes: { firstName: 'Dave' },
+              },
+            },
+          }),
+        },
+      });
+
+      await waitFor('[data-test-message-idx="0"]');
+      assert
+        .dom('[data-test-message-idx="0"] [data-test-ai-avatar]')
+        .doesNotHaveClass(
+          'ai-avatar-animated',
+          'ai bot patch message does not have a spinner',
+        );
+    });
   });
 
   test('it loads a card and renders its isolated view', async function (assert) {