Before trying to load command code refs, we need to ensure they are using absolute URLs

Author: lukemelia

packages/base/code-ref.gts

@@ -19,20 +19,13 @@ import { restartableTask } from 'ember-concurrency';
 import { consume } from 'ember-provide-consume-context';
 import {
   type ResolvedCodeRef,
+  isUrlLike,
   CardURLContextName,
 } from '@cardstack/runtime-common';
 import { not } from '@cardstack/boxel-ui/helpers';
 import { BoxelInput } from '@cardstack/boxel-ui/components';
 import CodeIcon from '@cardstack/boxel-icons/code';
 
-function moduleIsUrlLike(module: string) {
-  return (
-    module.startsWith('http') ||
-    module.startsWith('.') ||
-    module.startsWith('/')
-  );
-}
-
 class BaseView extends Component<typeof CodeRefField> {
   <template>
     <div data-test-ref>
@@ -122,7 +115,7 @@ export default class CodeRefField extends FieldDef {
       ...codeRef,
       ...(opts?.maybeRelativeURL &&
       !opts?.useAbsoluteURL &&
-      moduleIsUrlLike(codeRef.module)
+      isUrlLike(codeRef.module)
         ? { module: opts.maybeRelativeURL(codeRef.module) }
         : {}),
     };
@@ -153,7 +146,7 @@ function maybeSerializeCodeRef(
   stack: CardDef[] = [],
 ) {
   if (codeRef) {
-    if (moduleIsUrlLike(codeRef.module)) {
+    if (isUrlLike(codeRef.module)) {
       // if a stack is passed in, use the containing card to resolve relative references
       let moduleHref =
         stack.length > 0

packages/host/app/services/matrix-service.ts

@@ -20,14 +20,16 @@ import { TrackedMap } from 'tracked-built-ins';
 import { v4 as uuidv4 } from 'uuid';
 
 import {
-  type LooseSingleCardDocument,
-  markdownToHtml,
-  splitStringIntoChunks,
+  aiBotUsername,
   baseRealm,
+  codeRefWithAbsoluteURL,
+  getClass,
   LooseCardResource,
+  markdownToHtml,
   ResolvedCodeRef,
-  aiBotUsername,
-  getClass,
+  splitStringIntoChunks,
+  type LooseSingleCardDocument,
+  isUrlLike,
 } from '@cardstack/runtime-common';
 
 import {
@@ -65,7 +67,11 @@ import { getRandomBackgroundURL, iconURLFor } from '@cardstack/host/lib/utils';
 import { getMatrixProfile } from '@cardstack/host/resources/matrix-profile';
 
 import type { Base64ImageField as Base64ImageFieldType } from 'https://cardstack.com/base/base64-image';
-import { BaseDef, type CardDef } from 'https://cardstack.com/base/card-api';
+import type {
+  relativeTo,
+  BaseDef,
+  CardDef,
+} from 'https://cardstack.com/base/card-api';
 import type * as CardAPI from 'https://cardstack.com/base/card-api';
 import type * as FileAPI from 'https://cardstack.com/base/file-api';
 import { type FileDef } from 'https://cardstack.com/base/file-api';
@@ -599,8 +605,12 @@ export default class MatrixService extends Service {
     }[] = [];
     const mappings = await basicMappings(this.loaderService.loader);
     for (let commandDef of commandDefinitions) {
-      const Command = await getClass(
+      let absoluteCodeRef = codeRefWithAbsoluteURL(
         commandDef.codeRef,
+        commandDef[Symbol.for('cardstack-relative-to') as typeof relativeTo],
+      ) as ResolvedCodeRef;
+      const Command = await getClass(
+        absoluteCodeRef,
         this.loaderService.loader,
       );
       const command = new Command(this.commandService.commandContext);

packages/host/tests/acceptance/commands-test.gts

@@ -191,6 +191,16 @@ module('Acceptance | Commands tests', function (hooks) {
       }
     }
 
+    class BoomCommand extends Command<undefined, undefined> {
+      static displayName = 'BoomCommand';
+      async getInputType() {
+        return undefined;
+      }
+      protected async run(): Promise<undefined> {
+        throw new Error('Boom!');
+      }
+    }
+
     class Person extends CardDef {
       static displayName = 'Person';
       @field firstName = contains(StringField);
@@ -385,6 +395,7 @@ module('Acceptance | Commands tests', function (hooks) {
           pet: mangoPet,
           friends: [mangoPet],
         }),
+        'boom-command.ts': { default: BoomCommand },
         'Skill/useful-commands.json': {
           data: {
             type: 'card',
@@ -413,6 +424,13 @@ module('Acceptance | Commands tests', function (hooks) {
                   },
                   executors: [],
                 },
+                {
+                  codeRef: {
+                    name: 'default',
+                    module: `/test/boom-command`,
+                  },
+                  executors: [],
+                },
               ],
               title: 'Useful Commands',
               description: null,

packages/runtime-common/code-ref.ts

@@ -8,7 +8,7 @@ import {
 import { Loader } from './loader';
 import { isField } from './constants';
 import { CardError } from './error';
-import { trimExecutableExtension } from './index';
+import { isUrlLike, trimExecutableExtension } from './index';
 
 export type ResolvedCodeRef = {
   module: string;
@@ -105,11 +105,15 @@ export function codeRefWithAbsoluteURL(
   opts?: { trimExecutableExtension?: true },
 ): CodeRef {
   if (!('type' in ref)) {
-    let moduleURL = new URL(ref.module, relativeTo);
-    if (opts?.trimExecutableExtension) {
-      moduleURL = trimExecutableExtension(moduleURL);
+    if (isUrlLike(ref.module)) {
+      let moduleURL = new URL(ref.module, relativeTo);
+      if (opts?.trimExecutableExtension) {
+        moduleURL = trimExecutableExtension(moduleURL);
+      }
+      return { ...ref, module: moduleURL.href };
+    } else {
+      return { ...ref };
     }
-    return { ...ref, module: moduleURL.href };
   }
   return { ...ref, card: codeRefWithAbsoluteURL(ref.card, relativeTo) };
 }

packages/runtime-common/index.ts

@@ -99,7 +99,11 @@ export const isNode =
   '[object process]';
 
 export { SupportedMimeType } from './router';
-export { VirtualNetwork, type ResponseWithNodeStream } from './virtual-network';
+export {
+  isUrlLike,
+  VirtualNetwork,
+  type ResponseWithNodeStream,
+} from './virtual-network';
 export { RealmAuthDataSource } from './realm-auth-data-source';
 
 export type {

packages/runtime-common/virtual-network.ts

@@ -208,7 +208,7 @@ export class VirtualNetwork {
   }
 }
 
-function isUrlLike(moduleIdentifier: string): boolean {
+export function isUrlLike(moduleIdentifier: string): boolean {
   return (
     moduleIdentifier.startsWith('.') ||
     moduleIdentifier.startsWith('/') ||