Skip to content

Commit cdb8083

Browse files
committed
added concrete version of test assertion percy was making
1 parent 6222add commit cdb8083

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

Diff for: packages/base/cards-grid.gts

+2-3
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,8 @@ class Isolated extends Component<typeof CardsGrid> {
183183
{
184184
filter: {
185185
not: {
186-
type: {
187-
module: `${baseRealm.url}cards-grid`,
188-
name: 'CardsGrid',
186+
eq: {
187+
_cardType: 'Cards Grid',
189188
},
190189
},
191190
},

Diff for: packages/host/tests/acceptance/operator-mode-acceptance-test.gts

+9
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,7 @@ module('Acceptance | operator mode tests', function (hooks) {
398398
assert.dom('[data-test-stack-card-index="0"]').exists(); // Index card opens in the stack
399399

400400
await waitFor(`[data-test-cards-grid-item="${testRealmURL}Pet/mango"]`);
401+
401402
assert
402403
.dom(`[data-test-cards-grid-item="${testRealmURL}Pet/mango"]`)
403404
.exists();
@@ -407,6 +408,14 @@ module('Acceptance | operator mode tests', function (hooks) {
407408
assert
408409
.dom(`[data-test-cards-grid-item="${testRealmURL}Person/fadhlan"]`)
409410
.exists();
411+
assert
412+
.dom(`[data-test-cards-grid-item="${testRealmURL}index"]`)
413+
.doesNotExist('grid cards do not show other grid cards');
414+
// this was an unspelled, but very valid assertion that percy is making
415+
// that I'm now making concrete
416+
assert
417+
.dom(`[data-test-cards-grid-item="${testRealmURL}grid"]`)
418+
.doesNotExist('grid cards do not show other grid cards');
410419
// this asserts that cards that throw errors during search
411420
// query deserialization (boom.json) are handled gracefully
412421
assert

0 commit comments

Comments
 (0)