cleanup

Author: habdelra

packages/host/tests/helpers/indexer.ts

@@ -89,7 +89,7 @@ type TestIndexRow =
 // 2. provide a card instance for each row in the indexed_cards table
 // 3. provide an object { card, data } where the card instance is used for each
 //    row in the indexed_cards table, as well as any additional fields that you
-//    will to set from the `data` object.
+//    wish to set from the `data` object.
 //
 // the realm version table will default to version 1 of the testRealmURL if no
 // value is supplied

packages/host/tests/unit/query-test.ts

@@ -17,11 +17,6 @@ import { testRealmURL, setupIndex, serializeCard } from '../helpers';
 
 let cardApi: typeof import('https://cardstack.com/base/card-api');
 let string: typeof import('https://cardstack.com/base/string');
-// let number: typeof import('https://cardstack.com/base/number');
-// let date: typeof import('https://cardstack.com/base/date');
-// let datetime: typeof import('https://cardstack.com/base/datetime');
-// let boolean: typeof import('https://cardstack.com/base/boolean');
-// let queryableValue: typeof queryableValueType;
 let { sqlSchema, resolvedBaseRealmURL } = ENV;
 
 module('Unit | query', function (hooks) {
@@ -38,11 +33,6 @@ module('Unit | query', function (hooks) {
 
     cardApi = await loader.import(`${baseRealm.url}card-api`);
     string = await loader.import(`${baseRealm.url}string`);
-    // number = await loader.import(`${baseRealm.url}number`);
-    // date = await loader.import(`${baseRealm.url}date`);
-    // datetime = await loader.import(`${baseRealm.url}datetime`);
-    // boolean = await loader.import(`${baseRealm.url}boolean`);
-    // queryableValue = cardApi.queryableValue;
 
     let { field, contains, CardDef } = cardApi;
     let { default: StringField } = string;
@@ -148,4 +138,5 @@ module('Unit | query', function (hooks) {
   });
 
   skip(`can filter using 'eq' thru nested fields`);
+  skip(`can leverage queryableValue hook in card definition`);
 });

packages/runtime-common/indexer/client.ts

@@ -250,12 +250,14 @@ export class IndexerDBClient {
 
     let on = filter.on ?? onRef;
 
-    // TODO: any, every, not, eq, contains, range
-
     if ('eq' in filter) {
       return this.eqCondition(filter, on);
     }
 
+    // TODO handle filters for: any, every, not, contains, and range
+    // refer to hub v2 for a good reference:
+    // https://github.dev/cardstack/cardstack/blob/d36e6d114272a9107a7315d95d2f0f415e06bf5c/packages/hub/pgsearch/pgclient.ts
+
     throw new Error(`Unknown filter: ${JSON.stringify(filter)}`);
   }