Skip to content

Commit e0a83a9

Browse files
committed
update start-base script with full URL and cleanup comments
1 parent c55ed0c commit e0a83a9

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ Instead of running `pnpm start:base`, you can alternatively use `pnpm start:all`
8484
| :4205 | `/test` realm for matrix client tests (playwright controlled) | 🚫 | 🚫 |
8585
| :4210 | Development Worker Manager (spins up 1 worker by default) || 🚫 |
8686
| :4211 | Test Worker Manager (spins up 1 worker by default) || 🚫 |
87-
| :4212 | Test Worker Manager for matrix client tests (playwright controlled - 1 worker) | | 🚫 |
87+
| :4212 | Test Worker Manager for matrix client tests (playwright controlled - 1 worker) || 🚫 |
8888
| :5001 | Mail user interface for viewing emails sent to local SMTP || 🚫 |
8989
| :5435 | Postgres DB || 🚫 |
9090
| :8008 | Matrix synapse server || 🚫 |

packages/matrix/helpers/isolated-realm-server.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export async function startServer() {
3131
process.env.MATRIX_URL = 'http://localhost:8008';
3232
process.env.REALM_SERVER_MATRIX_USERNAME = 'realm_server';
3333

34-
let worker = spawn(
34+
let workerManager = spawn(
3535
'ts-node',
3636
[
3737
`--transpileOnly`,
@@ -50,13 +50,13 @@ export async function startServer() {
5050
stdio: ['pipe', 'pipe', 'pipe', 'ipc'],
5151
},
5252
);
53-
if (worker.stdout) {
54-
worker.stdout.on('data', (data: Buffer) =>
53+
if (workerManager.stdout) {
54+
workerManager.stdout.on('data', (data: Buffer) =>
5555
console.log(`worker: ${data.toString()}`),
5656
);
5757
}
58-
if (worker.stderr) {
59-
worker.stderr.on('data', (data: Buffer) =>
58+
if (workerManager.stderr) {
59+
workerManager.stderr.on('data', (data: Buffer) =>
6060
console.error(`worker: ${data.toString()}`),
6161
);
6262
}

packages/realm-server/scripts/start-base.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@ NODE_ENV=development \
2626
--path='../base' \
2727
--username='base_realm' \
2828
--fromUrl='https://cardstack.com/base/' \
29-
--toUrl='/base/'
29+
--toUrl='http://localhost:4201/base/'

0 commit comments

Comments
 (0)