Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realm: Add Sentry #1084

Merged
merged 18 commits into from
Mar 26, 2024
Merged

realm: Add Sentry #1084

merged 18 commits into from
Mar 26, 2024

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Mar 8, 2024

This adds a /_boom route to deliberately trigger an error and also reports when there’s an indexing error. Are there other errors that should be reported?

It took a lot of experimentation to get it working in the Fastboot environment, let me know if there’s a better way.

@backspace backspace added the enhancement New feature or request label Mar 8, 2024
@backspace backspace self-assigned this Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Test Results

538 tests  ±0   534 ✔️ ±0   7m 59s ⏱️ -39s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit ce5beaf. ± Comparison against base commit 6c2be48.

This pull request removes 538 and adds 538 tests. Note that renamed tests count towards both.
Chrome 122.0 ‑ Acceptance | Freestyle: smoke check
Chrome 122.0 ‑ Acceptance | basic tests: glimmer-scoped-css smoke test
Chrome 122.0 ‑ Acceptance | basic tests: visiting realm root
Chrome 122.0 ‑ Acceptance | code submode tests: Clicking card in search panel opens card JSON in editor
Chrome 122.0 ‑ Acceptance | code submode tests: can handle error when user puts unidentified domain in card URL bar
Chrome 122.0 ‑ Acceptance | code submode tests: card preview live updates when index changes
Chrome 122.0 ‑ Acceptance | code submode tests: card preview will show in the 3rd column when submode is set to code
Chrome 122.0 ‑ Acceptance | code submode tests: card-catalog does not offer to "create new card" when editing linked fields in code mode
Chrome 122.0 ‑ Acceptance | code submode tests: changes cursor position when selected module declaration is changed
Chrome 122.0 ‑ Acceptance | code submode tests: changes selected module declaration when cursor position is changed
…
Chrome 123.0 ‑ Acceptance | Freestyle: smoke check
Chrome 123.0 ‑ Acceptance | basic tests: glimmer-scoped-css smoke test
Chrome 123.0 ‑ Acceptance | basic tests: visiting realm root
Chrome 123.0 ‑ Acceptance | code submode tests: Clicking card in search panel opens card JSON in editor
Chrome 123.0 ‑ Acceptance | code submode tests: can handle error when user puts unidentified domain in card URL bar
Chrome 123.0 ‑ Acceptance | code submode tests: card preview live updates when index changes
Chrome 123.0 ‑ Acceptance | code submode tests: card preview will show in the 3rd column when submode is set to code
Chrome 123.0 ‑ Acceptance | code submode tests: card-catalog does not offer to "create new card" when editing linked fields in code mode
Chrome 123.0 ‑ Acceptance | code submode tests: changes cursor position when selected module declaration is changed
Chrome 123.0 ‑ Acceptance | code submode tests: changes selected module declaration when cursor position is changed
…
This pull request removes 4 skipped tests and adds 4 skipped tests. Note that renamed tests count towards both.
Chrome 122.0 ‑ Integration | card-editor: can create a specialized a new card to populate a linksTo field
Chrome 122.0 ‑ Integration | operator-mode: can create a specialized a new card to populate a linksTo field
Chrome 122.0 ‑ Integration | operator-mode: can create a specialized a new card to populate a linksToMany field
Chrome 122.0 ‑ Integration | search-index > query: can filter on an array of primitive fields inside a containsMany using 'eq'
Chrome 123.0 ‑ Integration | card-editor: can create a specialized a new card to populate a linksTo field
Chrome 123.0 ‑ Integration | operator-mode: can create a specialized a new card to populate a linksTo field
Chrome 123.0 ‑ Integration | operator-mode: can create a specialized a new card to populate a linksToMany field
Chrome 123.0 ‑ Integration | search-index > query: can filter on an array of primitive fields inside a containsMany using 'eq'

♻️ This comment has been updated with latest results.

This is what the documentation suggests, it seems errors
are swallowed otherwise.
@jurgenwerk
Copy link
Contributor

Wondering if we should report when indexing errors happens too?

@backspace
Copy link
Contributor Author

ya definitely, I first just wanted to be able to see any failure in Sentry 🤓

@backspace backspace marked this pull request as draft March 18, 2024 22:03
@backspace backspace marked this pull request as ready for review March 20, 2024 23:40
@backspace backspace requested a review from a team March 20, 2024 23:40
Copy link
Contributor

@habdelra habdelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with this approach 👍

# Conflicts:
#	packages/realm-server/main.ts
@backspace backspace merged commit 94d0beb into main Mar 26, 2024
17 of 18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the realm/sentry-cs-6602 branch March 26, 2024 16:10
backspace added a commit that referenced this pull request Apr 11, 2024
This part of #1084 turned out to be unnecessary as we expect indexing
errors from userland data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants