-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
realm: Add Sentry #1084
realm: Add Sentry #1084
Conversation
Test Results538 tests ±0 534 ✔️ ±0 7m 59s ⏱️ -39s Results for commit ce5beaf. ± Comparison against base commit 6c2be48. This pull request removes 538 and adds 538 tests. Note that renamed tests count towards both.
This pull request removes 4 skipped tests and adds 4 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
This is what the documentation suggests, it seems errors are swallowed otherwise.
Wondering if we should report when indexing errors happens too? |
ya definitely, I first just wanted to be able to see any failure in Sentry 🤓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree with this approach 👍
# Conflicts: # packages/realm-server/main.ts
This part of #1084 turned out to be unnecessary as we expect indexing errors from userland data.
This adds a
/_boom
route to deliberately trigger an error and also reports when there’s an indexing error. Are there other errors that should be reported?It took a lot of experimentation to get it working in the Fastboot environment, let me know if there’s a better way.