host: Add realm icon in attached cards #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will probably break things visually.
We want the extra padding for the delete icon.
burieberry
reviewed
Mar 12, 2024
| }; | ||
| } | ||
|
|
||
| export class CardPill extends Component<CardPillSignature> { |
There was a problem hiding this comment.
There's actually another CardPill component in components/ai-assistant/card-picker/index. That is the one we're using when cards are attached in the chat input area of the ai-assistant panel. It would be good if we could consolidate them. The difference would be to not to display the remove button. The styles should be the same otherwise.
There was a problem hiding this comment.
👍🏻 thanks, I’ve merged them now successfully 🎉
I couldn’t find anything referencing this in tests… it could be attached with splattributes anyway?
I’m having weird type failures locally…!
|
@cardstack/boxel-developers Luke suggested that more people check this out as the |
habdelra
reviewed
Mar 16, 2024
habdelra
approved these changes
Mar 16, 2024
delete-merged-branch
bot
deleted the
host/ai-message-attached-card-realm-icon-cs-6551
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This necessitated adding the ability to not render card chrome so I could insert the icon within the border. A box component now accepts
@displayContainer, it defaults totruebut we usefalseon the attached cards in atom format to include the icon.