ui: Update ember-{basic-dropdown,power-select} #1088
Conversation
This does include a patch to change the element type for the dropdown content element.
This was causing a peer dependency conflict.
This should fix the peer dependency build problem?
What happened???
# Conflicts: # packages/boxel-motion-test-app/package.json # packages/boxel-motion/package.json # packages/boxel-motion/test-app/package.json # pnpm-lock.yaml
# Conflicts: # pnpm-lock.yaml
Needed as a peer dependency of ember-power-select?
backspace
force-pushed
the
ember-basic-dropdown-8-cs-6621
branch
from
2f04348 to
305edb4
Compare
| import type { Dropdown } from './basic-dropdown.ts'; | ||
| export interface BasicDropdownContentSignature { | ||
| - Element: Element; | ||
| + Element: HTMLElement; |
There was a problem hiding this comment.
I chose to patch this because our types expect HTMLElement (does Element even make sense?) but I didn’t want to have to override the whole type for this one line.
Will this fix the Percy weirdness?
This reverts commit 6c14b2f.
I think the other one is the crux!
| @@ -1,4 +1,5 @@ | |||
| {{page-title 'Boxel Components'}} | |||
| <BasicDropdownWormhole /> | |||
There was a problem hiding this comment.
According to the migration documentation this should also happen in host but doing so resulted in strange Percy diffs like this:
When I used the application I didn’t see anything like this but since the existing setup worked fine with dropdowns, I left it.
There was a problem hiding this comment.
So we r not following the recommendation of the migration docs?
Perhaps this is a bug tht can be handled in another ticket.
There was a problem hiding this comment.
@backspace try moving the <BasicDropdownWormhole/> after {{outlet}} I think that works
There was a problem hiding this comment.
When I put it there I still get the strange Percy diffs, also when I put it after CardPrerender. I don’t love deviating from the documentation but I think <BasicDropdownWormhole /> is just emitting that container so it’s probably fine?
backspace
changed the title
|
Hmmm not sure if this affected stuff. Cos I have been working off this branch Screen.Recording.2024-03-18.at.21.38.23.movBefore click After click |
Did you build The dropdown works in the preview deployment so I think all is well? |
|
Related to what #1088 (comment). I think once you add the component there are 2 divs with the same id 'ember-basic-dropdown-wormhole". Because this code is still hanging around -- leading to unexpected behaviour. References Funnily. The issue I faced is when the wormhole div was somewhat missing but I really dont know why this happened. I can recreate by removing the div with the id in the html EDIT: Owh nvm. I can see you actually tried it 4f7680f |
The new versions include types which lets us remove our custom ones. This cascaded into updating some other dependencies to fix peer dependency resolution and various other build problems:
@babel/core@ember/test-helpersember-cli-babelember-concurrencyember-page-title