Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update past-sessions list based on last activity #1096

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Update past-sessions list based on last activity #1096

merged 6 commits into from
Mar 18, 2024

Conversation

burieberry
Copy link
Contributor

  • Takes into account potentially missing timestamps and the events array not being in order
  • Also updated the format of the date on the list, based on designs

@github-actions GitHub Actions
Copy link

Test Results

531 tests  ±0   527 ✔️ ±0   7m 25s ⏱️ +16s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit dc3392d. ± Comparison against base commit 2b28723.

@burieberry burieberry requested review from a team and habdelra March 15, 2024 21:01
backspace
backspace approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this locally, works well! (The preview deployment didn’t have the assistant 🧐)

@burieberry burieberry requested a review from a team March 18, 2024 16:48
@burieberry burieberry merged commit 0f70f81 into main Mar 18, 2024
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cs-6623-past-session-order branch March 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backspace backspace backspace approved these changes

@habdelra habdelra Awaiting requested review from habdelra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burieberry @backspace