-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "View Code" button and panel in chat #1102
Conversation
Test Results537 tests +1 533 ✔️ +1 7m 57s ⏱️ -7s Results for commit 0d3b968. ± Comparison against base commit 4a7bec2. This pull request removes 536 and adds 537 tests. Note that renamed tests count towards both.
This pull request removes 4 skipped tests and adds 4 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this locally and it works well, I’ll leave it up to you whether the scrolling situation I commented with is worth addressing.
@@ -86,6 +86,7 @@ export default class NewSession extends Component<Signature> { | |||
padding: var(--boxel-sp-4xs); | |||
font: 700 var(--boxel-font); | |||
line-height: 1.5; | |||
text-wrap: pretty; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t know about this, nice 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check the scroll. Yes I just found out about this property and liked it. However it may have caused the panel's right side alignment issue on percy, so I might revert this.
panel
toroom-message
so as to load it only once