Update to Ember 5.4 #1118
Merged
Update to Ember 5.4 #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe all the Ember packages need this?
This is built in now.
This reverts commit 0fdf1c1.
What does one do for v2 addons?
backspace
changed the base branch from
ember-pre-5-deprecations-cs-6611
to
main
# Conflicts: # packages/boxel-motion/addon/package.json # packages/boxel-ui/addon/package.json # packages/boxel-ui/test-app/package.json # pnpm-lock.yaml
This hopefully will end errors like this: https://github.com/cardstack/boxel/actions/runs/8474124443/job/23219905897#step:9:2947
habdelra
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly standard/mechanical update, with a lot of blueprint changes, some type and lint fixes.
ember/no-empty-glimmer-component-classesstarted flagging missed instances, so this includes some conversions toTemplateOnlyComponent<template>so I renamed a few signatures to avoid Prettier lint errors 😳cachedin@glimmer/trackinghas types now 🎉 so@ts-expect-errorcan go away for that import