-
Notifications
You must be signed in to change notification settings - Fork 11
ui: Remove padding from icons #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
approved these changes
Apr 4, 2024
Thanks for checking this out, @lukemelia, I kept it in draft because the size change has cascading effects, did you see the Percy diffs?
|
wrong PR!
f9cf273
to
fbd8b24
Compare
burieberry
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes padding from icons so they’ll be sized consistently, see the results in the preview. It started off just being about the inconsistency in alignment of the pencil icon here in the chat session menu, where it looked like this:
Now:
I used SVG Crop to crop the icons. I looked at using
svgo-autocrop
andsvg-autocrop
but neither worked because of mysterious Puppeteer problems, it didn’t seem worth the added complexity, but it does mean that we have to manually ensure new icons don’t have padding.I’ve adjusted the use of icons to make things look the same but there are slight differences!
For the special case where there’s a “crossed out” version (realm write permissions), I added
icon-pencil-not-crossed-out
which isicon-pencil-crossed-out
with the crossing-out stroke hidden, the pencil is slightly smaller to allow for the stroke to cover it.