Skip to content

Fix AI panel trigger covering card catalog #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Apr 13, 2024

Screenshot 2024-04-13 at 13 13 51

Previously, you could also click on ai button when choosing a card. You can see the percy change. After this change, the button is overlayed (greyed out) and trying to click on it will close the modal

Copy link

github-actions bot commented Apr 13, 2024

Test Results

584 tests  ±0   580 ✔️ ±0   8m 39s ⏱️ -18s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 0546eeb. ± Comparison against base commit db6f490.

♻️ This comment has been updated with latest results.

@tintinthong tintinthong force-pushed the cs-6673-fix-card-chooser-covers-ai-panel-trigger branch from 6826cf4 to 8a80bdc Compare April 14, 2024 04:35
@tintinthong tintinthong requested review from burieberry and a team April 15, 2024 02:25
@jurgenwerk jurgenwerk requested a review from a team April 15, 2024 06:53
@tintinthong
Copy link
Contributor Author

I am actually uncertain why z-index of the modal keep on increasing when you chooseCard?

@burieberry did have a PR to remove these but it was reverted.

@tintinthong tintinthong force-pushed the cs-6673-fix-card-chooser-covers-ai-panel-trigger branch from 6dae6fe to 0546eeb Compare April 15, 2024 12:29
@tintinthong tintinthong merged commit a0830bb into main Apr 16, 2024
@delete-merged-branch delete-merged-branch bot deleted the cs-6673-fix-card-chooser-covers-ai-panel-trigger branch April 16, 2024 01:04
@tintinthong tintinthong changed the title Fix Card Catalog covering AI panel trigger button Fix AI panel trigger covering card catalog Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants