do we need to manipulate z-index?? #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burieberry
approved these changes
Apr 15, 2024
tintinthong
force-pushed
the
stop-changing-z-index
branch
from
5820ef4 to
409cc1f
Compare
jurgenwerk
approved these changes
Apr 16, 2024
Yea this was my initial thought too. And I tested this it seemed ok. |
tintinthong
commented
Apr 18, 2024
| @@ -256,7 +256,7 @@ export default class SubmodeLayout extends Component<Signature> { | |||
| margin-right: 0; | |||
| background-color: var(--boxel-ai-purple); | |||
| box-shadow: var(--boxel-deep-box-shadow); | |||
| z-index: calc(var(--boxel-modal-z-index) - 1); | |||
| z-index: calc(var(--boxel-modal-z-index) - 2); | |||
There was a problem hiding this comment.
I had to change this because the ai button should be hidden behind the overlay. Lets see if percy shows us anything
modal z index: 15
overlay z index: 15-1
ai chat btn: 15-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this when i noticed that the z-index was increasing as I close and open the card catalog -- which seems weird to me.