Use dynamic context for "card context" #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
commented
Apr 22, 2024
lukemelia
commented
Apr 22, 2024
lukemelia
force-pushed
the
dynamic-scope
branch
from
d92c3d0 to
91cd9f7
Compare
lukemelia
requested review from
backspace,
jurgenwerk,
burieberry,
IanCal,
habdelra,
ef4,
tintinthong and
FadhlanR
jurgenwerk
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM, I've checked the https://github.com/customerio/ember-provide-consume-context addon, looks great to be able to pass things down so easily
tintinthong
approved these changes
Apr 23, 2024
habdelra
reviewed
Apr 23, 2024
| }; | ||
|
|
||
| export class CardContextConsumer extends Component<CardContextConsumerSignature> { | ||
| @consume(CardContextName) declare dynamicCardContext: CardContext; |
habdelra
reviewed
Apr 23, 2024
| @@ -21,6 +21,7 @@ | |||
| "tracked-built-ins": "^2.0.1" | |||
| }, | |||
| "peerDependencies": { | |||
| "ember-provide-consume-context": "^0.3.1", | |||
habdelra
reviewed
Apr 23, 2024
| @@ -173,9 +175,10 @@ export default class OperatorModeStackItem extends Component<Signature> { | |||
| return this.args.index + 1 < this.args.stackItems.length; | |||
| } | |||
|
|
|||
| @provide(CardContextName) | |||
habdelra
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stepping stone toward our refactor from the @model/@fields template API. It introduces ember-provide-consume-context and uses it to convert the way that provide the cardComponentModifier and actions to cards from using prop drilling to using dynamic context.