ci: Fix main attachment of Playwright status link #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurgenwerk
approved these changes
Apr 22, 2024
delete-merged-branch
bot
deleted the
ci/playwright-report-status-on-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects an error in #1169; you can see when you view the statuses attached to the commit where I merged it that a report is generated but the status is not attached because the API URL is for pull requests only, not pushes to a branch. This adds a fallback for the SHA when the CI job is running outside of a PR.
In
c056b17I hacked the workflow to run onpushto this branch and the status was correctly attached: