Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dynamic context for defaultFormat #1195

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Use dynamic context for defaultFormat #1195

merged 2 commits into from
Apr 25, 2024

Conversation

lukemelia
Copy link
Contributor

@lukemelia lukemelia commented Apr 23, 2024 •
edited
Loading

Builds on #1191

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

Test Results

600 tests  ±0   596 ✔️ ±0   11m 52s ⏱️ + 1m 0s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit d61146b. ± Comparison against base commit 930eede.

♻️ This comment has been updated with latest results.

@lukemelia lukemelia marked this pull request as ready for review April 23, 2024 22:37
backspace
backspace approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have the strongest understanding of these mechanisms but it looks good from a high level!

@lukemelia lukemelia force-pushed the dynamic-scope-ii branch 2 times, most recently from 2830793 to 636ea3b Compare April 25, 2024 19:52
@lukemelia
Copy link
Contributor Author

I reviewed interactively with @ef4

@lukemelia lukemelia merged commit 999a01d into main Apr 25, 2024
25 checks passed
@delete-merged-branch delete-merged-branch bot deleted the dynamic-scope-ii branch April 25, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backspace backspace backspace approved these changes

@IanCal IanCal Awaiting requested review from IanCal

@habdelra habdelra Awaiting requested review from habdelra

@jurgenwerk jurgenwerk Awaiting requested review from jurgenwerk

@ef4 ef4 Awaiting requested review from ef4

@tintinthong tintinthong Awaiting requested review from tintinthong

@FadhlanR FadhlanR Awaiting requested review from FadhlanR

@burieberry burieberry Awaiting requested review from burieberry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukemelia @backspace