Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Fix linting #1206

Merged
merged 6 commits into from
May 6, 2024
Merged

common: Fix linting #1206

merged 6 commits into from
May 6, 2024

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Apr 29, 2024

Typechecking wasn’t happening for packages/runtime-common. The commits fix sets of type errors. skipLibCheck is frowned upon by some but used in other packages so ¯_(ツ)_/¯

@backspace backspace added bug Something isn't working chore labels Apr 29, 2024
@backspace backspace self-assigned this Apr 29, 2024
Copy link

Test Results

601 tests  ±0   597 ✔️ ±0   11m 33s ⏱️ -2s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit ba25889. ± Comparison against base commit 9b5eb56.

Copy link

github-actions bot commented May 2, 2024

Host Tests (In-Memory Index) Test Results

607 tests  ±0   602 ✔️ ±0   10m 20s ⏱️ -57s
    1 suites ±0       5 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 28442dc. ± Comparison against base commit 7a4b13e.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Chrome 124.0 ‑ Acceptance | interact submode tests > 1 stack > when permission is updated after user has obtained the token: retrieve a new JWT if recevive 401 error
Chrome 124.0 ‑ Acceptance | interact submode tests > 1 stack > when permission is updated after user has obtained the token: retrieve a new JWT on  401 error

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 2, 2024

Host Tests (DB Index) Test Results

607 tests  ±0   604 ✔️ ±0   11m 41s ⏱️ +23s
    1 suites ±0       3 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 28442dc. ± Comparison against base commit 7a4b13e.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Chrome 124.0 ‑ Acceptance | interact submode tests > 1 stack > when permission is updated after user has obtained the token: retrieve a new JWT if recevive 401 error
Chrome 124.0 ‑ Acceptance | interact submode tests > 1 stack > when permission is updated after user has obtained the token: retrieve a new JWT on  401 error

♻️ This comment has been updated with latest results.

@backspace backspace requested a review from a team May 3, 2024 21:04
@backspace backspace marked this pull request as ready for review May 3, 2024 21:04
Copy link
Contributor

@habdelra habdelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m fine with this (I’m probably the one that started using skipLibCheck in the first place). There is a trade off. Type issues in any external imports (which include imports from other workspaces in our repo), will be ignored. So long as we are comfortable with this I think it’s fine. Since we are running type checks in all the TS workspaces in our repo I think we have our bases covered.

@backspace backspace merged commit 6b3005d into main May 6, 2024
29 of 30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the common/lint branch May 6, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants