Integrate postgres into realm server #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g index WIP requests to talk to server while it is being built up
…indexer-in-realm-server
habdelra
requested review from
lukemelia,
backspace,
IanCal,
jurgenwerk,
ef4,
tintinthong,
FadhlanR and
burieberry
backspace
approved these changes
May 2, 2024
| private handlers: Map<string, Function> = new Map(); | ||
| private notifiers: Map<number, Deferred<any>> = new Map(); | ||
|
|
||
| private jobRunner: WorkLoop | undefined; | ||
| private notificationRunner: WorkLoop | undefined; | ||
|
|
||
| constructor(private pgClient: PgAdapter) {} |
There was a problem hiding this comment.
I didn’t know this existed to set the property 😯
| if [ -n "$PG_INDEXER" ]; then | ||
| while ! check_postgres_ready; do | ||
| printf '.' | ||
| sleep 1 |
There was a problem hiding this comment.
Should there be a timeout like I’m working on adding here?
| printf '.' | ||
| sleep 1 | ||
| done | ||
| fi |
There was a problem hiding this comment.
Since this is repeated across a few scripts, maybe it should be extracted?
…indexer-in-realm-server
delete-merged-branch
bot
deleted the
cs-6639-use-postgres-indexer-in-realm-server
branch
jurgenwerk
reviewed
May 3, 2024
| await percySnapshot(assert); | ||
| // Percy is failing to capture this snapshot for some | ||
| // reason. creating issue for this CS-6780 | ||
| // await percySnapshot(assert); |
There was a problem hiding this comment.
Already tracking this in CS-6767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables postgres in the app 🎉
When you start your servers you can use:
to start the servers with postgres. Everything should be automatic--the DB will migrate automatically as part of starting the server. This introduces both the postgres based index as well as our postgres based queuing system.
you can connect to your DB using psql: