host: Remove build-time realm URLs #1527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn’t resolve git misery…
I thought this might fix some of the problems, it didn’t, maybe I’ll return to this later but for now I’m committing it so I can merge from the main branch.
Is there a better way? I’m sure it’s flaky because it sometimes hasn’t reacted to the account data event.
This is simpler now because auth will fail when the account data event is processed.
This could have been problematic with the removal of defaultURL but it’s unused!
Finally!
…to host/no-realm-url-config-cs-7036
backspace
changed the base branch from
main
to
host/more-mock-matrix-client
backspace
changed the base branch from
host/more-mock-matrix-client
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only build-time realm configuration now is
resolvedBaseRealmURL.